diff options
author | Tom de Vries <tdevries@suse.de> | 2024-02-24 11:00:20 +0100 |
---|---|---|
committer | Slava Barinov <v.barinov@samsung.com> | 2024-07-18 15:04:58 +0300 |
commit | 1cf50aff01147aa6bec8673d4ff2c152258666ea (patch) | |
tree | b8cdf9439779a730fa4b1a55eedd0824c82b2187 | |
parent | 08e0627341ce376aca7af180fce13229b19d98f4 (diff) | |
download | binutils-sandbox/v.orazov/enable_gdb.tar.gz binutils-sandbox/v.orazov/enable_gdb.tar.bz2 binutils-sandbox/v.orazov/enable_gdb.zip |
[gdb/build] Fix static cast of virtual basetizen_base_devsandbox/v.orazov/enable_gdb
With this change in bfd/development.sh:
...
-development=true
+development=false
...
we run into:
...
In file included from tui-data.h:28:0,
from tui-command.c:24:
gdb-checked-static-cast.h: In instantiation of \
‘T gdb::checked_static_cast(V*) [with T = tui_cmd_window*; V = tui_win_info]’:
tui-command.c:65:15: required from here
gdb-checked-static-cast.h:63:14: error: cannot convert from pointer to base \
class ‘tui_win_info’ to pointer to derived class ‘tui_cmd_window’ because \
the base is virtual
T result = static_cast<T> (v);
^~~~~~~~~~~~~~~~~~
...
Fix this by using dynamic_cast instead of gdb::checked_static_cast in
TUI_CMD_WIN and TUI_STATUS_WIN.
Tested on x86_64-linux, with development set to false.
Reported-By: Robert Xiao <spam_hole@shaw.ca>
Reported-By: Simon Marchi <simark@simark.ca>
Approved-By: Tom Tromey <tom@tromey.com>
PR build/31399
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31399
Change-Id: I555bdebf617b8d5c4688fc0a1a9fe878dbde0af8
-rw-r--r-- | gdb/tui/tui-data.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/tui/tui-data.h b/gdb/tui/tui-data.h index 1714f5ae455..90ab01f79af 100644 --- a/gdb/tui/tui-data.h +++ b/gdb/tui/tui-data.h @@ -296,9 +296,9 @@ extern struct tui_win_info *tui_win_list[MAX_MAJOR_WINDOWS]; #define TUI_DATA_WIN \ (gdb::checked_static_cast<tui_data_window *> (tui_win_list[DATA_WIN])) #define TUI_CMD_WIN \ - (gdb::checked_static_cast<tui_cmd_window *> (tui_win_list[CMD_WIN])) + (dynamic_cast<tui_cmd_window *> (tui_win_list[CMD_WIN])) #define TUI_STATUS_WIN \ - (gdb::checked_static_cast<tui_status_window *> (tui_win_list[STATUS_WIN])) + (dynamic_cast<tui_status_window *> (tui_win_list[STATUS_WIN])) /* All the windows that are currently instantiated, in layout order. */ |