summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2023-03-11Fix stencil op in render pass stencil read only testsziga-lunarg1-6/+8
If depth stencil attachment is in a read-only layout for the stencil aspect and stencil test is enabled, all stencil ops must be KV_STENCIL_OP_KEEP Components: Vulkan VK-GL-CTS issue: 4317 Affected tests: dEQP-VK.renderpass.* Change-Id: I1ba6dcb11525c600d42e1653b0aa347e67117adf
2023-03-09Fix checking support in texture filtering testsziga-lunarg1-1/+2
The tests use mipmaps even if the test parameter for mipmaps is false and the check support function does not do that Components: Vulkan VK-GL-CTS issue: 4294 Affected tests: dEQP-VK.texture.filtering.2d_array.* Change-Id: Iabd33803fc952f3ea4c7598674fd9f58b53070d4
2023-03-09Wrong assumption in robustness testsMarcin KaƄtoch1-1/+16
Accept cases, such as <0.0f, 123.0f>, <123.0f, 0.0f> for out of bounds memory, as those can be correctly generated by the compiler. VK-GL-CTS issue: 4288 Components: Vulkan Affects: dEQP-VK.robustness.robustness2.* Change-Id: If54aedf4277d93b404056274e397e7f73c05872b
2023-03-09Fix timeout case in vktSynchronizationTimelineSemaphoreTestsMatthew Netsch1-3/+8
Loop was inverted and race condition on error status. Components: Vulkan VK-GL-CTS Issue: 4282 Affects: dEQP-VK.synchronization*.timeline_semaphore.wait.poll* Change-Id: I8811dbcbdc34130c8bf4ced7e4e3013ca411da05
2023-02-17Fix overlapping mutable descriptor typesRicardo Garcia1-4/+5
Some mutable decriptor test variants create pools with several mutable descriptor entries with overlapping types, which is forbidden by the spec and results in VUID-VkDescriptorPoolCreateInfo-pPoolSizes-04787. Affects: dEQP-VK.binding_model.mutable_descriptor.single_and_array.* Components: Vulkan VK-GL-CTS issue: 4289 Change-Id: Ia4274a6f13c52257c0e84e8711a8d883dab0cc36
2023-02-10Change HLSL to avoid nested runtimeArray in SPIR-VMaciej Jurga1-19/+36
Replace a structure used in RWStructuredBuffer by HLSL tessellation evaluation shader with two RWStructuredBuffers of a basic type. Old structure had a dynamic length array member, that caused glslang to produce invalid SPIR-V with nested runtimeArray decoration. Components: Vulkan VK-GL-CTS issue: 2697 Affected tests: dEQP-VK.tessellation.fractional_spacing.* Change-Id: I4b55ca3688289b6ca22fa642972dc28e11a5659f
2023-02-02Fix tolerance values when VK_COMPONENT_SWIZZLE_ONE is in useJoe Withers1-4/+13
Tolerance values were being increased unnecessarily for tests using VK_COMPONENT_SWIZZLE_ONE. This change overwrites any SWIZZLE_ONE with SWIZZLE_ZERO when applying a swizzle to the threshold values, to maintain a strict tolerance. Affects: dEQP-VK.pipeline.sampler.border_swizzle.* Components: Vulkan Change-Id: Ie72e4a97e502bdbb74ea412951f5a9481434d489
2023-02-02Enable CTS log files to exceed 2GB on 32-bit Linux buildCharles Johnston1-0/+6
Components: Framework VK-GL-CTS issue: 4238 Change-Id: Ie9c58364f0bb44c3b2a15a71585d4801d0b12063
2023-02-02Prevent warnings from Amber failing the CTS buildCharlie Turner1-0/+8
With clang++-16, I'm seeing lots of cases like, /home/cturner/src/vk-gl-cts/external/amber/src/src/float16_helper.cc:66:42: error: unchecked operation on raw buffer in expression [-Werror,-Wunsafe-buffer-usage] uint32_t sign = (static_cast<uint32_t>(value[1]) & 0x80) << 24U; Inhibit all warning messages for Clang, GCC & MSVC. Components: Framework, Vulkan Change-Id: I1910780048d8828a61733a5f5f36404f8a8184b0
2023-01-27Fix image barrier in ray tracing pipeline build testsziga-lunarg1-1/+1
Use the correct combination of access mask and pipeline stage Components: Vulkan VK-GL-CTS issue: 4202 Affected tests: dEQP-VK.ray_tracing_pipeline.build.* Change-Id: I185c3787b6bfa24c79f5fbd063fc041d000ae0f4
2023-01-27Do not allow to call vkSetEvent after submission, which is invalid.Hyunjun Ko4-207/+530
The spec says: "If a command buffer submission waits for any events to be signaled, the application must ensure that command buffer submissions will be able to complete without any subsequent operations by the application. Events signaled by the host must be signaled before the command buffer waits on those events." This means it's not valid to signal an event on the host after submission of a command buffer containing a wait for the event. Also it forces the command buffer to stop for an unknown amount of time, as much as the time needed for the host to signal the event with vkSetEvent. However there were some CTS tests doing like this, which should be fixed. For vktApiExternalMemoryTests.cpp, There was a vkSetEvent call after submission to hold a command to be executed before signaling to get a native file descriptor, which is not valid. So the tests should allow to get -1. Also we do an atomic calculation to avoid singalling right after submit when trying to get a native fd. The simple atomic calculation is evaluated to take about 10ms. For vktApiExternalMemoryTests.cpp and vktMemoryExternalMemoryHostTests.cpp, replace vkSetEvent with timeline semaphore to signal from the host. Affects: dEQP-VK.api.external.semaphore.* dEQP-VK.api.external.fence.* dEQP-VK.api.command_buffers.secondary_execute_twice dEQP-VK.memory.external_memory_host.synchronization.synchronization VK-GL-CTS Issue: 4075 Components: Vulkan Change-Id: I5544bb15a418bbbbd6552ca04bec673a56ca3109
2023-01-27Add missing buffer memory flushSviatoslav Peleshko1-0/+1
We do a memcpy to the buffer, but don't flush it. If we don't use host-coherent memory for this buffer it might sometimes lead to corruption (when we later invalidate the buffer's memory to get results from the shader). Components: Vulkan Affected tests: dEQP-VK.query_pool.statistics_query.compute_shader_invocations.* dEQP-VK.query_pool.statistics_query.*.compute_shader_invocations.* Signed-off-by: Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com> Change-Id: I2f9491d6cacf39fe6a00d7624e2aa474615421ce
2023-01-23Use correct extent for 1D compute texel_view_compatible testsConnor Abbott1-2/+2
We weren't sanitizing the size in the parameters, resulting in copyDataToImage() passing an extent with a non-1 height to when uploading to a 1D image. Sanitize fullSize, and remove a case where where we were workaround it not being sanitized. Components: Vulkan Affects: dEQP-VK.image.texel_view_compatible.compute.basic.1d_image.* VK-GL-CTS Issue: 4143 Change-Id: Icdb50c09137a947f47b1afc7426e53e73c31f689
2023-01-20Fix merge error in FSR srlayered testsSlawomir Cygan1-3/+3
Reapply last chunk from 853897a8722 which seems to have been broken in a merge: layercount value was passed instead of viewFormatCount. This is fixes a regression introduced by 10618, which was exposed after being promoted to vulkan-cts-1.2.8+. Components: Vulkan VK-GL-CTS Issue: 4224 VK-GL-CTS Issue: 4226 Affects: dEQP-VK.fragment_shading_rate.* Change-Id: Ib8f5b180368fe9bf3c32f349c2475a4932f30fbf
2023-01-19Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8Piotr Byszewski3-38/+69
Change-Id: Iaae2490f0ec3069759a7660dee175cfdc3668622
2023-01-17Update scripts for Android buildAitor Camacho3-41/+77
- Use d8 instead of dx due to deprecation - Use apksigner instead of jarsigner for signature scheme v2 required by newer SDKs - Move apk signing to be last step (required for signature scheme v2) - Force uncompressed arsc files (required for SDK versions 30 and up) - Add '--tool-api' argument for selecting build tools version - Add permission for reading external storage in manifest VK-GL-CTS Issue: 4163 Components: Framework Change-Id: Iea4429f861148168ffe680cdf9a497cb467b8d6a
2023-01-13Remove duplicated test groupsPiotr Byszewski7-33652/+5
While adding support for dynamic rendering to renderpass group a mistake was made that added 3 groups with the same tests to both renderpass2 group and legacy renderpass group. This mistake was fixed on 1.3.1 branch but is present on 1.2.8 and 1.3.0. There is no need to execute same tests twice - this change removes duplicates. This fix should be propagated only to 1.3.0. Components: Vulkan VK-GL-CTS issue: 4225 Removed tests: dEQP-VK.renderpass.depth_stencil_resolve.* dEQP-VK.renderpass.fragment_density_map.* dEQP-VK.renderpass2.multiple_subpasses_multiple_command_buffers.test Change-Id: I571e499ead038acf1744c356b884f2be966e3c15
2023-01-13Fix oldLayout in image barriers in copy and blit testsziga-lunarg1-1/+3
The same barriers are used twice, but the oldLayout is not updated Components: Vulkan VK-GL-CTS issue: 4054 Affected tests: dEQP-VK.api.copy_and_blit.* Change-Id: I8fd622846a2c9ce840ec6bfb5a431ae66a5af06f
2023-01-13Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8Piotr Byszewski9-54217/+325
Change-Id: I1139cfa0a1d27a08bd6d3c72b2d65fd754edc886
2023-01-13Remove invalid separate_layouts tests on older branchesziga-lunarg6-28693/+325
These tests were fixed, but only on 1.3.2 newer, they should be removed on older branches Components: Vulkan VK-GL-CTS issue: 3527 Removed tests: dEQP-VK.renderpass2.depth_stencil_resolve.*separate_layouts.* Change-Id: I467ea14cc5c2eb26723cc9e2453ea5a11a1556b9
2023-01-05Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8Piotr Byszewski1-4/+4
Change-Id: Iea24c631e95fad0dbf694e67f141c243fda3a3d9
2023-01-05Fix 2d image views in fragment shading rate testsziga-lunarg1-5/+6
If viewType is VK_IMAGE_VIEW_TYPE_2D then subresourceRange.layerCount must be 1 Components: Vulkan VK-GL-CTS issue: 4124 Affected tests: dEQP-VK.fragment_shading_rate.* Change-Id: I32db55ce0785a2d91c391625bfed312d5e7371f0
2022-12-16Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8Piotr Byszewski6-42/+34
Change-Id: Ib14adccc08aa0dd8767e6dea0199e021885d292d
2022-12-16Fix errors in sparse resources testsziga-lunarg3-24/+27
VK_EXT_shader_image_atomic_int64 extension must be enabled on the device if used Feature structs from non-enabled extensions must not be passed to VkDeviceCreateInfo pNext Checks if image formats are supported are missing Components: Vulkan VK-GL-CTS issue: 4122 Affected tests: dEQP-VK.sparse_resources.shader_intrinsics.* Change-Id: I4fcac8eae1d53826d5ef5f8a7dcc04bfe95f7360
2022-12-16Fix subpass dependency dstStageMask in shader_fragment_mask testsziga-lunarg1-1/+1
Stage VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUT_BIT must be included if access mask is VK_ACCESS_COLOR_ATTACHMENT_READ_BIT Components: Vulkan VK-GL-CTS issue: 4120 Affected tests: dEQP-VK.pipeline.*.shader_fragment_mask.* Change-Id: Iea2a62ff5781c50ad39d707a8eb0f1f4ce344f48
2022-12-16Set correct pipeline barrier between clear image and trace rayYun Shu1-1/+1
The image is cleared with fixed value, then used as write destination in ray tracing shaders. The pipeline barrier set for the image is incorrect between clear command and trace ray command. Affects: dEQP-VK.ray_tracing_pipeline.large_shader_set.* Components: Vulkan VK-GL-CTS issue: 4137 Change-Id: I41dd55d51ea995c4c878e053f6d617b2e38ba5b1
2022-12-16Add check for the return value of vkGetPhysicalDeviceImageFormatProperties2Amber1-2/+5
Also do not attempt to create images for depth/stencil usage using color formats. Components: Vulkan VK-GL-CTS issue: 4125 Affected tests: dEQP-VK.api.external.memory.dma_buf.suballocated.image.info Change-Id: If1f41b967d03f1b862c85277d6fe30b20ab1a110
2022-12-08Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8Matthew Netsch4-11/+18
Change-Id: If5512ea90e2442bc7304502d78cc3b1333f53479
2022-12-08Write gl_PointSize in depth testsziga-lunarg1-0/+1
Some depth tests use VK_PRIMITIVE_TOPOLOGY_POINT_LIST but the shaders don't write the point size Components: Vulkan VK-GL-CTS issue: 4153 Affected tests: dEQP-VK.pipeline.*.depth.* Change-Id: Idaa9ea65f7c43ca02d7780d1825d4558b712a133
2022-12-08Add check if format is supported in external memory host testsziga-lunarg1-0/+5
Format properties for format used for color attachment must contain VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT Components: Vulkan VK-GL-CTS issue: 4156 Affected tests: dEQP-VK.memory.external_memory_host.bind_image_memory_and_render.* Change-Id: Ib0346cbc849b94a5af67e5645cc057ca392f9b2f
2022-12-08Fix invalid framebuffer in compressed texture 3D testsziga-lunarg1-7/+7
Framebuffer attachments must be created with viewType not equal to VK_IMAGE_VIEW_TYPE_3D Components: Vulkan VK-GL-CTS issue: 4118 Affected tests: dEQP-VK.texture.compressed_3D.* Change-Id: I9ae036d02daa3579567bf514c70bf623a0bc9aa9
2022-12-08Fix flushing memory range in memory model shared testsziga-lunarg1-4/+5
Each size of pMemRanges in vkFlushMappedMemoryRanges must be either a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize or equal to the size of memory Components: Vulkan VK-GL-CTS issue: 4123 Affected tests: dEQP-VK.memory_model.shared.* Change-Id: I0f3ea96736aa73eb92c7809c04297923d84e348c
2022-12-01Re-add texture filtering tests with rgba10x6 formatziga-lunarg4-5/+33
These tests were removed when only the check for formatRgba10x6WithoutYCbCrSampler feature was missing Components: Vulkan VK-GL-CTS issue: 3646 New tests: dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_nearest dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_linear dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_nearest_mipmap_nearest dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_linear_mipmap_nearest dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_nearest_mipmap_linear dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_linear_mipmap_linear Change-Id: Ida3cb9f1abd95f57908b9540c65605cbb1b40fa3
2022-12-01Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8Matthew Netsch2-1/+8
Change-Id: I36f8b8142517f82d581ee2bc365a97ff37a63dc8
2022-12-01Fix invalid usage of descriptorCount for inline uniformHyunjun Ko1-0/+7
blocks. Affects: dEQP-VK.binding_model.descriptorset_random.*.iublimit* VK-GL-CTS Issue: 4115 Components: Vulkan Change-Id: I649d86b859ca642b47c1fda4aa915e1d6616c898
2022-11-24Fix for 16 to 8-bit storage spirv_assembly testsGary Sweet1-1/+1
The output buffer was being made smaller than it was required to hold all the results. Robust buffer accesss prevented the writes from trampling memory after the buffer, but could mean that the data in the valid part of the buffer was incorrectly written instead. This change makes the output buffer large enough to prevent the out-of-bounds writes. Components: Vulkan VK-GL-CTS issue: 4126 Affected tests: dEQP-VK.spirv_assembly.instruction.graphics.8bit_storage.storagebuffer_int_16_to_8.* Change-Id: I59145be8012f7a31037ee3fee4d7ac96a198bc00
2022-11-17Add missing check for rgba10x6 featuresziga-lunarg1-0/+4
Feature formatRgba10x6WithoutYCbCrSampler must be supported if image is created with format VK_FORMAT_R10x6G10X6B10X6A10X6_UNORM_4PACK16 and level count is greater than 1 Components: Vulkan VK-GL-CTS issue: 3992 Affected tests: dEQP-VK.pipeline.image_view.view_type.*.format.* Change-Id: I63f7d2083ea85d9f6232540d72178bd8172b13d5
2022-11-17Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8Matthew Netsch2-3/+4
Change-Id: I571894bfd5fc1ab88a09272d7452522bce76165d
2022-11-17Fix failed memory map check for reconvergence testsChristopher Hambacher1-2/+2
Tests are checking for ResourceError, when a failed memory map will return TestError. Components: Vulkan VK-GL-CTS issue: 4100 Affected tests: dEQP-VK.reconvergence.* Change-Id: I61fcc9f29fe19ff592b74986ac39a7e3958f06e8
2022-11-15Limit number of concurrent query poolsRicardo Garcia1-1/+2
The max concurrency tests use a heuristic to try to estimate a safe number of objects of different types that the implementation would be able to create, with an upper limit of 16384 objects. However, in some implementations the creation of these objects have external limitations that make the safe value hard to guess by only looking at system and device memory usage. For example, the kernel driver may impose further limits on the total number of certain objects. This is reflected in the current tests with some lower hardcoded limits for some types of objects, like instances, devices, synchronization primitives and pipeline caches. This commit halves the limit of concurrent query pools being tested to a value that doesn't trigger any issue in the Mesa RPi drivers. Affects: dEQP-VK.api.object_management.max_concurrent.query_pool VK-GL-CTS issue: 4106 Components: Vulkan Change-Id: If88c6aa1ecd3d9c18892b38cb55907a82eee6cf8
2022-11-10Add missing checks for geometry shader supportRicardo Garcia3-8/+18
Affects: dEQP-VK.multiview.*geometry* dEQP-VK.subgroups.*geometry* dEQP-VK.fragment_shading_rate.*.gs* VK-GL-CTS issue: 4064 Components: Vulkan Change-Id: I64a3b6d7adc8da7671817710c4a4882db2c27035
2022-11-10Add missing read without format bit check in robustness testsziga-lunarg1-0/+4
If buffer view is being read as storage texel buffer with image format of OpTypeImage being Unknown then the view's buffer features must contain VK_FORMAT_FEATURE_2_STORAGE_READ_WITHOUT_FORMAT_BIT Components: Vulkan VK-GL-CTS issue: 4047 Affected tests: dEQP-VK.robustness.robustness2.bind.* Change-Id: I46e5482fbfea3a945b133dbca0e020159049516f
2022-11-10Fix stencilAttachmentFormat in inverted depth ranges testsziga-lunarg1-1/+1
If format is not VK_FORMAT_UNDEFINED in VKPipelineRenderingCreateInfo::stencilAttachmentFormat then it must be a format that includes a stencil aspect Components: Vulkan VK-GL-CTS issue: 4046 Affected tests: dEQP-VK.draw.dynamic_rendering.inverted_depth_ranges.* Change-Id: Ia0dcb1989b8ace78632d26dd0a1e3c1101f5f547
2022-11-10Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8Matthew Netsch11-40/+63
Change-Id: I46781852d8da0c1c3d65c9435cf93cd05ce1781b
2022-11-10Fix viewport width in FSR with multiviewport testsziga-lunarg1-4/+4
Tests with extent 1x1 create viewport with width equal to 0.0f Components: Vulkan VK-GL-CTS issue: 4057 Affected tests: dEQP-VK.fragment_shading_rate.* Change-Id: I99a050348de83d1790320bd5d6d711722dd1fbaf
2022-11-10Fix image barrier oldLayout in timeline semaphore testsziga-lunarg1-13/+13
Image layout in image barrier must be updated after first transition Components: Vulkan VK-GL-CTS issue: 4049 Affected tests: dEQP-VK.synchronization.timeline_semaphore.one_to_n.* Change-Id: I7fde2342007a3ec9c2562375fd634539e186acdc
2022-11-10Fix barrier in ray tracing pipeline build testsziga-lunarg1-1/+1
If access mask is VK_ACCEDSS_ACCELERATION_STRUCTURE_WRITE_BIT_KHR then stage must be VK_PIPELINE_STAGE_ACCELERATION_STRUCTURE_BUILD_BIT_KHR Components: Vulkan VK-GL-CTS issue: 4053 Affected tests: dEQP-VK.ray_tracing_pipeline.build.* Change-Id: I0a8080881f944319aae2417e5f9fe3297b933dd7
2022-11-10Fix pMutableDescriptorTypeLists in mutable descriptor testsziga-lunarg1-1/+1
pMutableDescriptorTypeLists between srcBinding and dstBinding must match exactly for copying descriptor sets Components: Vulkan VK-GL-CTS issue: 4051 Affected tests: dEQP-VK.binding_model.mutable_descriptor.* Change-Id: I64445e84ccd4872789a3db8b15e005d36c08d8a4
2022-11-10Fix to reset dynamicDenstiyMap after dynamic subsampled tets done.Hyunjun Ko1-0/+1
Affects: dEQP-VK.*.fragment_density_map.*.static_nonsubsampled* dEQP-VK.*.fragment_density_map.*.deferred_nonsubsampled* VK-GL-CTS Issue: 4062 Components: Vulkan Change-Id: Ib347bd6e4734b2928ccacfa17dd01dfc134301bb
2022-11-10Fix flush memory range in ssbo corner case testsziga-lunarg1-3/+8
The size in VKMappedMemoryRange used in vkFlushMappedMemoryRanges must either be a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize or offset + size must be equal to the size of memory Components: Vulkan VK-GL-CTS issue: 4044 Affected tests: dEQP-VK.ssbo.corner_case.* Change-Id: I9ea2ee1e055b55ec39988a6ec0539cd3219937f4