From b75d8dc5642b71eb029e7cd38031a32029e736cc Mon Sep 17 00:00:00 2001 From: Masahiro Yamada Date: Fri, 26 Jun 2020 15:13:33 +0900 Subject: treewide: convert bd_t to struct bd_info by coccinelle The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include #include void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: @@ typedef bd_t; @@ -bd_t +struct bd_info Signed-off-by: Masahiro Yamada --- cmd/bdinfo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'cmd/bdinfo.c') diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c index b7f5f710b4..8b2c105e77 100644 --- a/cmd/bdinfo.c +++ b/cmd/bdinfo.c @@ -45,7 +45,7 @@ void bdinfo_print_mhz(const char *name, unsigned long hz) printf("%-12s= %6s MHz\n", name, strmhz(buf, hz)); } -static void print_bi_dram(const bd_t *bd) +static void print_bi_dram(const struct bd_info *bd) { #ifdef CONFIG_NR_DRAM_BANKS int i; @@ -66,7 +66,7 @@ __weak void arch_print_bdinfo(void) int do_bdinfo(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) { - bd_t *bd = gd->bd; + struct bd_info *bd = gd->bd; #ifdef DEBUG bdinfo_print_num("bd address", (ulong)bd); -- cgit v1.2.3