summaryrefslogtreecommitdiff
path: root/include/search.h
diff options
context:
space:
mode:
authorRasmus Villemoes <rasmus.villemoes@prevas.dk>2020-02-27 13:56:12 +0000
committerTom Rini <trini@konsulko.com>2020-04-24 10:09:59 -0400
commit080019b86c997a9b7e13bc7b8f476fbf9a0e5f3c (patch)
tree79d730d1f93c336251fe391c7a157455f8465f9e /include/search.h
parent34284970a1736e7be35bef74e4f8e429e703c1ce (diff)
downloadu-boot-080019b86c997a9b7e13bc7b8f476fbf9a0e5f3c.tar.gz
u-boot-080019b86c997a9b7e13bc7b8f476fbf9a0e5f3c.tar.bz2
u-boot-080019b86c997a9b7e13bc7b8f476fbf9a0e5f3c.zip
make env_entry::callback conditional on !CONFIG_SPL_BUILD
The callback member of struct env_entry is always NULL for an SPL build. Removing it thus saves a bit of run-time memory in the SPL (when CONFIG_SPL_ENV_SUPPORT=y) since struct env_entry is embedded in struct env_entry_node - i.e. about 2KB for the normal case of 512+change hash table entries. Two small fixups are needed for this, all other references to the callback member are already under !CONFIG_SPL_BUILD: Don't initialize .callback in set_flags() - hsearch_r doesn't use that value anyway. And make env_callback_init() initialize ->callback to NULL for a new entry instead of relying on an unused or deleted entry having NULL in ->callback. Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk> Reviewed-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'include/search.h')
-rw-r--r--include/search.h2
1 files changed, 2 insertions, 0 deletions
diff --git a/include/search.h b/include/search.h
index 0469a852e0..8f87dc72ce 100644
--- a/include/search.h
+++ b/include/search.h
@@ -29,8 +29,10 @@ enum env_action {
struct env_entry {
const char *key;
char *data;
+#ifndef CONFIG_SPL_BUILD
int (*callback)(const char *name, const char *value, enum env_op op,
int flags);
+#endif
int flags;
};