diff options
| author | Mateusz Zalega <m.zalega@samsung.com> | 2014-04-28 21:13:24 +0200 |
|---|---|---|
| committer | Lukasz Majewski <l.majewski@samsung.com> | 2014-05-05 08:00:28 +0200 |
| commit | 711b931f90e44ff1248cd73c15f64485470d86ff (patch) | |
| tree | ba210677e3fa0c50a74a357a997931530a4e12db /include/dfu.h | |
| parent | 75504e9592745021006cb8905b5ff5a51d9d1cb3 (diff) | |
| download | u-boot-711b931f90e44ff1248cd73c15f64485470d86ff.tar.gz u-boot-711b931f90e44ff1248cd73c15f64485470d86ff.tar.bz2 u-boot-711b931f90e44ff1248cd73c15f64485470d86ff.zip | |
dfu: mmc: raw data write fix
When user attempted to perform a raw write using DFU (vide
dfu_fill_entity_mmc) with MMC interface not initialized before,
get_mmc_blk_size() reported invalid (zero) block size - it wasn't
possible to write ie. a new u-boot image.
This commit fixes that by initializing MMC device before use in
dfu_fill_entity_mmc().
While fixing initialization sequence, I had to change about half of
dfu_fill_entity_mmc's body, so I refactored it on the way to make it,
IMHO, considerably more comprehensible.
Being left as dead code, get_mmc_blk_size() was removed.
Tested on Samsung Goni.
Signed-off-by: Mateusz Zalega <m.zalega@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Acked-by: Tom Rini <trini@ti.com>
Cc: Minkyu Kang <mk7.kang@samsung.com>
Diffstat (limited to 'include/dfu.h')
| -rw-r--r-- | include/dfu.h | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/include/dfu.h b/include/dfu.h index 6c71ecbe35..dcd3215d06 100644 --- a/include/dfu.h +++ b/include/dfu.h @@ -64,11 +64,6 @@ struct ram_internal_data { unsigned int size; }; -static inline unsigned int get_mmc_blk_size(int dev) -{ - return find_mmc_device(dev)->read_bl_len; -} - #define DFU_NAME_SIZE 32 #define DFU_CMD_BUF_SIZE 128 #ifndef CONFIG_SYS_DFU_DATA_BUF_SIZE |