diff options
author | Hoyeonjiki Kim <jigi.kim@gmail.com> | 2020-11-17 12:32:08 +0900 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2020-11-18 13:46:58 -0500 |
commit | 2a0a577aad4337eab24812911df248a9a8c4ebd0 (patch) | |
tree | 74a7797fbcb210c4519adf8d2a5af57db8b42081 /env | |
parent | e800d715e01daffa9a5078c974f4568d6ef9e7c3 (diff) | |
download | u-boot-2a0a577aad4337eab24812911df248a9a8c4ebd0.tar.gz u-boot-2a0a577aad4337eab24812911df248a9a8c4ebd0.tar.bz2 u-boot-2a0a577aad4337eab24812911df248a9a8c4ebd0.zip |
env: mmc: Correct partition comparison in mmc_offset_try_partition
The function mmc_offset_try_partition searches the MMC partition for
locating environment data, by comparing the partition names with config
"u-boot,mmc-env-parition". However, it only compares the first word-size
bytes (size of 'const char *'), which may make the function to find
unintended partition.
Correct the function not to partially compare the partition name with
config "u-boot,mmc-env-partition".
Fixes: c9e87ba66540 ("env: Save environment at the end of an MMC partition")
Signed-off-by: Hoyeonjiki Kim <jigi.kim@gmail.com>
Reviewed-by: Wolfgang Denk <wd@denx.de>
Diffstat (limited to 'env')
-rw-r--r-- | env/mmc.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -42,7 +42,7 @@ static inline int mmc_offset_try_partition(const char *str, int copy, s64 *val) if (ret < 0) return ret; - if (!strncmp((const char *)info.name, str, sizeof(str))) + if (!strncmp((const char *)info.name, str, sizeof(info.name))) break; } |