diff options
author | Tom Rini <trini@konsulko.com> | 2023-12-13 11:51:53 -0500 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2023-12-13 11:51:53 -0500 |
commit | 9565771076c2d4b0193f1741b3990695ac33c1f3 (patch) | |
tree | 076f2a305250c83e4e3c5acf0e6492507d10babb /drivers/misc | |
parent | bfe3c7b93b9e722340e0e4950e886a46ba41244e (diff) | |
parent | 8632b36b96d38a85f2e71603a6f90ec9e4e5e37e (diff) | |
download | u-boot-9565771076c2d4b0193f1741b3990695ac33c1f3.tar.gz u-boot-9565771076c2d4b0193f1741b3990695ac33c1f3.tar.bz2 u-boot-9565771076c2d4b0193f1741b3990695ac33c1f3.zip |
Merge patch series "bootm: Refactoring to reduce reliance on CMDLINE (part A)"
To quote the author:
It would be useful to be able to boot an OS when CONFIG_CMDLINE is
disabled. This could allow reduced code size.
Standard boot provides a way to handle programmatic boot, without
scripts, so such a feature is possible. The main impediment is the
inability to use the booting features of U-Boot without a command line.
So the solution is to avoid passing command arguments and the like to
code in boot/
A similar process has taken place with filesystems, for example, where
we have (somewhat) separate Kconfig options for the filesystem commands
and the filesystems themselves.
This series starts the process of refactoring the bootm logic so that
it can be called from standard boot without using the command line.
Mostly it removes the use of argc, argv and cmdtbl from the internal
logic.
Some limited tidy-up is included, but this is kept to smaller patches,
rather than trying to remove all #ifdefs etc. Some function comments
are added, however.
A simple programmatic boot is provided as a starting point.
This work will likely take many series, so this is just the start.
Size growth with this series for firefly-rk3288 (Thumb2) is:
arm: (for 1/1 boards) all +23.0 rodata -49.0 text +72.0
This should be removed by:
https://source.denx.de/u-boot/custodians/u-boot-dm/-/issues/11
but it is not included in this series as it is already large enough.
No functional change is intended in this series.
Changes in v3:
- Add a panic if programmatic boot fails
- Drop RFC tag
Changes in v2:
- Add new patch to adjust position of unmap_sysmem() in boot_get_kernel()
- Add new patch to obtain command arguments
- Fix 'boot_find_os' typo
- Pass in the command name
- Use the command table to provide the command name, instead of "bootm"
Diffstat (limited to 'drivers/misc')
-rw-r--r-- | drivers/misc/gsc.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/misc/gsc.c b/drivers/misc/gsc.c index 65c9c2c6ce..feb02f9706 100644 --- a/drivers/misc/gsc.c +++ b/drivers/misc/gsc.c @@ -531,10 +531,10 @@ static int do_gsc(struct cmd_tbl *cmdtp, int flag, int argc, char * const argv[] if (!gsc_wd_disable(dev)) return CMD_RET_SUCCESS; } else if (strcasecmp(argv[1], "thermal") == 0) { - char *cmd, *val; + const char *cmd, *val; - cmd = (argc > 2) ? argv[2] : NULL; - val = (argc > 3) ? argv[3] : NULL; + cmd = cmd_arg2(argc, argv); + val = cmd_arg3(argc, argv); if (!gsc_thermal(dev, cmd, val)) return CMD_RET_SUCCESS; } |