diff options
| author | Mattijs Korpershoek <mkorpershoek@baylibre.com> | 2024-07-24 11:51:06 +0200 |
|---|---|---|
| committer | Mattijs Korpershoek <mkorpershoek@baylibre.com> | 2024-08-22 09:23:33 +0200 |
| commit | 61faa6dd21f661cab95aa00a6660441a5f04f8db (patch) | |
| tree | d705ef7ff236566e5b8b84436b800b1690beea8f /cmd | |
| parent | 0b06e052fb153958d470209dab237f12796cb0da (diff) | |
| download | u-boot-61faa6dd21f661cab95aa00a6660441a5f04f8db.tar.gz u-boot-61faa6dd21f661cab95aa00a6660441a5f04f8db.tar.bz2 u-boot-61faa6dd21f661cab95aa00a6660441a5f04f8db.zip | |
cmd: bcb: Fix segfault on invalid block device
When blk_get_dev() fails, block NULL and gets de-referenced in
the error path by a printf(), resulting in a crash.
This can be reproduced on sandbox with:
$ ./u-boot --command "bcb load mmc 0 0"
Fix the message by using the functions arguments (iface, devnum)
instead.
Note: partition (being a global static initialized) can be used safely.
This issue has been reported by coverity [1]
[1] https://lore.kernel.org/all/20240723141844.GF989285@bill-the-cat/
Fixes: dfeb4f0d7935 ("cmd: bcb: extend BCB C API to allow read/write the fields")
Reviewed-by: Dmitrii Merkurev <dimorinny@google.com>
Link: https://lore.kernel.org/r/20240724-bcb-crash-v1-1-44caff15bce4@baylibre.com
Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Diffstat (limited to 'cmd')
| -rw-r--r-- | cmd/bcb.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -172,8 +172,8 @@ static int __bcb_initialize(const char *iface, int devnum, const char *partp) return CMD_RET_SUCCESS; err_read_fail: - printf("Error: %d %d:%s read failed (%d)\n", block->uclass_id, - block->devnum, partition->name, ret); + printf("Error: %s %d:%s read failed (%d)\n", iface, devnum, + partition->name, ret); __bcb_reset(); return CMD_RET_FAILURE; } |