diff options
| author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 15:13:33 +0900 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2020-07-17 09:30:13 -0400 |
| commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
| tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /board/liebherr | |
| parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) | |
| download | u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.tar.gz u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.tar.bz2 u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.zip | |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'board/liebherr')
| -rw-r--r-- | board/liebherr/display5/display5.c | 2 | ||||
| -rw-r--r-- | board/liebherr/display5/spl.c | 2 | ||||
| -rw-r--r-- | board/liebherr/mccmon6/spl.c | 2 | ||||
| -rw-r--r-- | board/liebherr/xea/xea.c | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/board/liebherr/display5/display5.c b/board/liebherr/display5/display5.c index ec55fdf0aa..ada7cf5eb7 100644 --- a/board/liebherr/display5/display5.c +++ b/board/liebherr/display5/display5.c @@ -136,7 +136,7 @@ int overwrite_console(void) } #if defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP) -int ft_board_setup(void *blob, bd_t *bd) +int ft_board_setup(void *blob, struct bd_info *bd) { fdt_fixup_ethernet(blob); return 0; diff --git a/board/liebherr/display5/spl.c b/board/liebherr/display5/spl.c index ac4f23f4d6..23959c2557 100644 --- a/board/liebherr/display5/spl.c +++ b/board/liebherr/display5/spl.c @@ -288,7 +288,7 @@ static struct fsl_esdhc_cfg usdhc_cfg = { .max_bus_width = 8, }; -int board_mmc_init(bd_t *bd) +int board_mmc_init(struct bd_info *bd) { displ5_set_iomux_usdhc_spl(); diff --git a/board/liebherr/mccmon6/spl.c b/board/liebherr/mccmon6/spl.c index b234f06220..56eae3b4e9 100644 --- a/board/liebherr/mccmon6/spl.c +++ b/board/liebherr/mccmon6/spl.c @@ -528,7 +528,7 @@ int board_mmc_getcd(struct mmc *mmc) return ret; } -int board_mmc_init(bd_t *bis) +int board_mmc_init(struct bd_info *bis) { int ret; u32 index = 0; diff --git a/board/liebherr/xea/xea.c b/board/liebherr/xea/xea.c index 4062c6fb82..9286f4c755 100644 --- a/board/liebherr/xea/xea.c +++ b/board/liebherr/xea/xea.c @@ -189,7 +189,7 @@ static int fdt_fixup_l2switch(void *blob) return 0; } -int ft_board_setup(void *blob, bd_t *bd) +int ft_board_setup(void *blob, struct bd_info *bd) { /* * i.MX28 L2 switch needs manual update (fixup) of eth MAC address |