diff options
author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 15:13:33 +0900 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2020-07-17 09:30:13 -0400 |
commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /arch/m68k | |
parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) | |
download | u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.tar.gz u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.tar.bz2 u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.zip |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'arch/m68k')
-rw-r--r-- | arch/m68k/cpu/mcf523x/cpu.c | 2 | ||||
-rw-r--r-- | arch/m68k/cpu/mcf52x2/cpu.c | 2 | ||||
-rw-r--r-- | arch/m68k/cpu/mcf532x/cpu.c | 2 | ||||
-rw-r--r-- | arch/m68k/cpu/mcf5445x/cpu.c | 2 | ||||
-rw-r--r-- | arch/m68k/cpu/mcf547x_8x/cpu.c | 2 | ||||
-rw-r--r-- | arch/m68k/lib/bdinfo.c | 2 | ||||
-rw-r--r-- | arch/m68k/lib/bootm.c | 10 |
7 files changed, 11 insertions, 11 deletions
diff --git a/arch/m68k/cpu/mcf523x/cpu.c b/arch/m68k/cpu/mcf523x/cpu.c index d521a8a2e4..a3a79fb4d2 100644 --- a/arch/m68k/cpu/mcf523x/cpu.c +++ b/arch/m68k/cpu/mcf523x/cpu.c @@ -108,7 +108,7 @@ int watchdog_init(void) * int board_eth_init(bd_t *bis) */ -int cpu_eth_init(bd_t *bis) +int cpu_eth_init(struct bd_info *bis) { return mcffec_initialize(bis); } diff --git a/arch/m68k/cpu/mcf52x2/cpu.c b/arch/m68k/cpu/mcf52x2/cpu.c index d3d4e30ad5..1ca28e46ce 100644 --- a/arch/m68k/cpu/mcf52x2/cpu.c +++ b/arch/m68k/cpu/mcf52x2/cpu.c @@ -423,7 +423,7 @@ int do_reset(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) * int board_eth_init(bd_t *bis) */ -int cpu_eth_init(bd_t *bis) +int cpu_eth_init(struct bd_info *bis) { return mcffec_initialize(bis); } diff --git a/arch/m68k/cpu/mcf532x/cpu.c b/arch/m68k/cpu/mcf532x/cpu.c index 72bfdf056b..805108f7ac 100644 --- a/arch/m68k/cpu/mcf532x/cpu.c +++ b/arch/m68k/cpu/mcf532x/cpu.c @@ -149,7 +149,7 @@ int watchdog_init(void) * create a board-specific function called: * int board_eth_init(bd_t *bis) */ -int cpu_eth_init(bd_t *bis) +int cpu_eth_init(struct bd_info *bis) { return mcffec_initialize(bis); } diff --git a/arch/m68k/cpu/mcf5445x/cpu.c b/arch/m68k/cpu/mcf5445x/cpu.c index 886f29d1b6..f5c1947b22 100644 --- a/arch/m68k/cpu/mcf5445x/cpu.c +++ b/arch/m68k/cpu/mcf5445x/cpu.c @@ -112,7 +112,7 @@ int print_cpuinfo(void) * int board_eth_init(bd_t *bis) */ -int cpu_eth_init(bd_t *bis) +int cpu_eth_init(struct bd_info *bis) { return mcffec_initialize(bis); } diff --git a/arch/m68k/cpu/mcf547x_8x/cpu.c b/arch/m68k/cpu/mcf547x_8x/cpu.c index 59cdfe70e4..76d2e77fc0 100644 --- a/arch/m68k/cpu/mcf547x_8x/cpu.c +++ b/arch/m68k/cpu/mcf547x_8x/cpu.c @@ -139,7 +139,7 @@ int watchdog_init(void) * int board_eth_init(bd_t *bis) */ -int cpu_eth_init(bd_t *bis) +int cpu_eth_init(struct bd_info *bis) { #if defined(CONFIG_FSLDMAFEC) mcdmafec_initialize(bis); diff --git a/arch/m68k/lib/bdinfo.c b/arch/m68k/lib/bdinfo.c index 971c47c306..fb4d1a52fd 100644 --- a/arch/m68k/lib/bdinfo.c +++ b/arch/m68k/lib/bdinfo.c @@ -13,7 +13,7 @@ DECLARE_GLOBAL_DATA_PTR; void arch_print_bdinfo(void) { - bd_t *bd = gd->bd; + struct bd_info *bd = gd->bd; #if defined(CONFIG_SYS_INIT_RAM_ADDR) bdinfo_print_num("sramstart", (ulong)bd->bi_sramstart); diff --git a/arch/m68k/lib/bootm.c b/arch/m68k/lib/bootm.c index aa17929b9e..320451144f 100644 --- a/arch/m68k/lib/bootm.c +++ b/arch/m68k/lib/bootm.c @@ -27,7 +27,7 @@ DECLARE_GLOBAL_DATA_PTR; #define LINUX_MAX_ARGS 256 static ulong get_sp (void); -static void set_clocks_in_mhz (bd_t *kbd); +static void set_clocks_in_mhz (struct bd_info *kbd); void arch_lmb_reserve(struct lmb *lmb) { @@ -54,8 +54,8 @@ int do_bootm_linux(int flag, int argc, char *const argv[], bootm_headers_t *images) { int ret; - bd_t *kbd; - void (*kernel) (bd_t *, ulong, ulong, ulong, ulong); + struct bd_info *kbd; + void (*kernel) (struct bd_info *, ulong, ulong, ulong, ulong); struct lmb *lmb = &images->lmb; /* @@ -79,7 +79,7 @@ int do_bootm_linux(int flag, int argc, char *const argv[], if (ret) goto error; - kernel = (void (*)(bd_t *, ulong, ulong, ulong, ulong))images->ep; + kernel = (void (*)(struct bd_info *, ulong, ulong, ulong, ulong))images->ep; debug("## Transferring control to Linux (at address %08lx) ...\n", (ulong) kernel); @@ -112,7 +112,7 @@ static ulong get_sp (void) return sp; } -static void set_clocks_in_mhz (bd_t *kbd) +static void set_clocks_in_mhz (struct bd_info *kbd) { char *s; |