summaryrefslogtreecommitdiff
path: root/fs/udf
diff options
context:
space:
mode:
authorBean Huo <beanhuo@micron.com>2023-06-26 07:55:18 +0200
committerAndrew Morton <akpm@linux-foundation.org>2023-08-18 10:12:07 -0700
commita524fcfe190da16bbf1311b6636f51d81f35d59a (patch)
tree9217a2cb9f783970dff36b7f59a50f2a954c5023 /fs/udf
parent489b7e72a63cbda11b3a2cd6c895b22917d53065 (diff)
downloadlinux-starfive-a524fcfe190da16bbf1311b6636f51d81f35d59a.tar.gz
linux-starfive-a524fcfe190da16bbf1311b6636f51d81f35d59a.tar.bz2
linux-starfive-a524fcfe190da16bbf1311b6636f51d81f35d59a.zip
fs: convert block_commit_write to return void
block_commit_write() always returns 0, this patch changes it to return void. Link: https://lkml.kernel.org/r/20230626055518.842392-3-beanhuo@iokpp.de Signed-off-by: Bean Huo <beanhuo@micron.com> Reviewed-by: Jan Kara <jack@suse.cz> Acked-by: Theodore Ts'o <tytso@mit.edu> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Andreas Dilger <adilger.kernel@dilger.ca> Cc: Christian Brauner <brauner@kernel.org> Cc: Joel Becker <jlbec@evilplan.org> Cc: Joseph Qi <joseph.qi@linux.alibaba.com> Cc: Luís Henriques <ocfs2-devel@oss.oracle.com> Cc: Mark Fasheh <mark@fasheh.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'fs/udf')
-rw-r--r--fs/udf/file.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/udf/file.c b/fs/udf/file.c
index 243840dc83ad..0292d75e60cc 100644
--- a/fs/udf/file.c
+++ b/fs/udf/file.c
@@ -63,13 +63,13 @@ static vm_fault_t udf_page_mkwrite(struct vm_fault *vmf)
else
end = PAGE_SIZE;
err = __block_write_begin(page, 0, end, udf_get_block);
- if (!err)
- err = block_commit_write(page, 0, end);
- if (err < 0) {
+ if (err) {
unlock_page(page);
ret = block_page_mkwrite_return(err);
goto out_unlock;
}
+
+ block_commit_write(page, 0, end);
out_dirty:
set_page_dirty(page);
wait_for_stable_page(page);