diff options
| author | Xiongfeng Wang <wangxiongfeng2@huawei.com> | 2022-12-01 12:01:27 +0800 |
|---|---|---|
| committer | Joerg Roedel <jroedel@suse.de> | 2022-12-02 11:45:33 +0100 |
| commit | 4bedbbd782ebbe7287231fea862c158d4f08a9e3 (patch) | |
| tree | e29f3c7bdff76e49762be071a55cad97f9c40383 /drivers/iommu | |
| parent | afca9e19cc720bfafc75dc5ce429c185ca93f31d (diff) | |
| download | linux-starfive-4bedbbd782ebbe7287231fea862c158d4f08a9e3.tar.gz linux-starfive-4bedbbd782ebbe7287231fea862c158d4f08a9e3.tar.bz2 linux-starfive-4bedbbd782ebbe7287231fea862c158d4f08a9e3.zip | |
iommu/vt-d: Fix PCI device refcount leak in dmar_dev_scope_init()
for_each_pci_dev() is implemented by pci_get_device(). The comment of
pci_get_device() says that it will increase the reference count for the
returned pci_dev and also decrease the reference count for the input
pci_dev @from if it is not NULL.
If we break for_each_pci_dev() loop with pdev not NULL, we need to call
pci_dev_put() to decrease the reference count. Add the missing
pci_dev_put() for the error path to avoid reference count leak.
Fixes: 2e4552893038 ("iommu/vt-d: Unify the way to process DMAR device scope array")
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Link: https://lore.kernel.org/r/20221121113649.190393-3-wangxiongfeng2@huawei.com
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'drivers/iommu')
| -rw-r--r-- | drivers/iommu/intel/dmar.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/iommu/intel/dmar.c b/drivers/iommu/intel/dmar.c index 5a8f780e7ffd..bc94059a5b87 100644 --- a/drivers/iommu/intel/dmar.c +++ b/drivers/iommu/intel/dmar.c @@ -820,6 +820,7 @@ int __init dmar_dev_scope_init(void) info = dmar_alloc_pci_notify_info(dev, BUS_NOTIFY_ADD_DEVICE); if (!info) { + pci_dev_put(dev); return dmar_dev_scope_status; } else { dmar_pci_bus_add_dev(info); |