diff options
| author | Jeff Moyer <jmoyer@redhat.com> | 2009-10-02 18:56:53 -0400 |
|---|---|---|
| committer | Jens Axboe <jens.axboe@oracle.com> | 2009-10-28 09:29:25 +0100 |
| commit | 1af60fbd759d31f565552fea315c2033947cfbe6 (patch) | |
| tree | e973002ee2496a9537526c8aef111f380071a1a0 /fs/direct-io.c | |
| parent | 1a1238a7dd48e48b3bba8f426a1d61c22c80d6d1 (diff) | |
| download | linux-stable-1af60fbd759d31f565552fea315c2033947cfbe6.tar.gz linux-stable-1af60fbd759d31f565552fea315c2033947cfbe6.tar.bz2 linux-stable-1af60fbd759d31f565552fea315c2033947cfbe6.zip | |
block: get rid of the WRITE_ODIRECT flag
Hi,
The WRITE_ODIRECT flag is only used in one place, and that code path
happens to also call blk_run_address_space. The introduction of this
flag, then, could result in the device being unplugged twice for every
I/O.
Further, with the batching changes in the next patch, we don't want an
O_DIRECT write to imply a queue unplug.
Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Diffstat (limited to 'fs/direct-io.c')
| -rw-r--r-- | fs/direct-io.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/direct-io.c b/fs/direct-io.c index 8b10b87dc01a..c86d35f142de 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c @@ -1124,7 +1124,7 @@ __blockdev_direct_IO(int rw, struct kiocb *iocb, struct inode *inode, int acquire_i_mutex = 0; if (rw & WRITE) - rw = WRITE_ODIRECT; + rw = WRITE_SYNC_PLUG; if (bdev) bdev_blkbits = blksize_bits(bdev_logical_block_size(bdev)); |