diff options
| author | Dirk Eibach <eibach@gdsys.de> | 2006-08-27 01:23:36 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-08-27 11:01:29 -0700 |
| commit | 01cfaf0d12ae5fa092cc916ca4066ee1598e857d (patch) | |
| tree | f4db2c5759345e4b06310b633b8cee241842bdf6 /drivers/char/lp.c | |
| parent | a0cc621f52a4dea10c34eeed6eb4e36b26db63dc (diff) | |
| download | linux-stable-01cfaf0d12ae5fa092cc916ca4066ee1598e857d.tar.gz linux-stable-01cfaf0d12ae5fa092cc916ca4066ee1598e857d.tar.bz2 linux-stable-01cfaf0d12ae5fa092cc916ca4066ee1598e857d.zip | |
[PATCH] char/moxa.c: fix endianess and multiple-card issues
While testing Moxa C218T/PCI on PowerPC 405EP I found that loading firmware
using the linux kernel driver fails because calculation of the checksum is
not endianess independent in the original code.
After I fixed this I found that uploading firmware in a system with
multiple cards causes a kernel oops. I had a look in the recent moxa
sources and found that they do some kind of locking there. Applying this
lock fixed the problem.
Alan sayeth:
Checksum changes are clearly correct. Other changes is an improvement but
not I think enough to handle malicious firmware attacks. That said such an
attacker has CAP_SYS_RAWIO anyway so that part is irrelevant except for
neatness.
[akpm@osdl.org: cleanups]
Signed-off-by: Dirk Eibach <eibach@gdsys.de>
Acked-by: Alan Cox <alan@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/char/lp.c')
0 files changed, 0 insertions, 0 deletions