summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Borkmann <dborkman@redhat.com>2013-02-08 03:04:34 +0000
committerBen Hutchings <ben@decadent.org.uk>2013-02-20 03:15:36 +0000
commit8f8623de49e036c4af246a7cfd9abdc1bb95cdea (patch)
treee7fe4765020c8354777634ca39d3ce2436ea7d2e
parent87deb9f94dedf6f69ccbd52031ddfe39a6ca4cf1 (diff)
downloadlinux-stable-8f8623de49e036c4af246a7cfd9abdc1bb95cdea.tar.gz
linux-stable-8f8623de49e036c4af246a7cfd9abdc1bb95cdea.tar.bz2
linux-stable-8f8623de49e036c4af246a7cfd9abdc1bb95cdea.zip
net: sctp: sctp_setsockopt_auth_key: use kzfree instead of kfree
[ Upstream commit 6ba542a291a5e558603ac51cda9bded347ce7627 ] In sctp_setsockopt_auth_key, we create a temporary copy of the user passed shared auth key for the endpoint or association and after internal setup, we free it right away. Since it's sensitive data, we should zero out the key before returning the memory back to the allocator. Thus, use kzfree instead of kfree, just as we do in sctp_auth_key_put(). Signed-off-by: Daniel Borkmann <dborkman@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
-rw-r--r--net/sctp/socket.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index fa8333bd6c30..5e0d86e1e214 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -3375,7 +3375,7 @@ static int sctp_setsockopt_auth_key(struct sock *sk,
ret = sctp_auth_set_key(sctp_sk(sk)->ep, asoc, authkey);
out:
- kfree(authkey);
+ kzfree(authkey);
return ret;
}