diff options
| author | Tejun Heo <tj@kernel.org> | 2009-02-12 10:34:32 +0900 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-02-20 14:36:55 -0800 |
| commit | 2da462eba7e5b585d54c17d76c6a662e4fbb3c32 (patch) | |
| tree | 2e84b8bc10074d2371777810e32e19a723049446 | |
| parent | 308151183cd07fc0cbce0404dbd04259ac9d2a41 (diff) | |
| download | linux-stable-2da462eba7e5b585d54c17d76c6a662e4fbb3c32.tar.gz linux-stable-2da462eba7e5b585d54c17d76c6a662e4fbb3c32.tar.bz2 linux-stable-2da462eba7e5b585d54c17d76c6a662e4fbb3c32.zip | |
sata_nv: give up hardreset on nf2
commit 7dac745b8e367c99175b8f0d014d996f0e5ed9e5 upstream.
Kernel bz#12176 reports that nf2 hardreset simply doesn't work. Give
up. Argh...
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Robert Hancock <hancockr@shaw.ca>
Reported-by: Saro <saro_v@hotmail.it>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/ata/sata_nv.c | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/drivers/ata/sata_nv.c b/drivers/ata/sata_nv.c index 89e3b7f617a0..8b6f9c093349 100644 --- a/drivers/ata/sata_nv.c +++ b/drivers/ata/sata_nv.c @@ -421,19 +421,21 @@ static struct ata_port_operations nv_generic_ops = { .hardreset = ATA_OP_NULL, }; -/* OSDL bz3352 reports that nf2/3 controllers can't determine device - * signature reliably. Also, the following thread reports detection - * failure on cold boot with the standard debouncing timing. +/* nf2 is ripe with hardreset related problems. + * + * kernel bz#3352 reports nf2/3 controllers can't determine device + * signature reliably. The following thread reports detection failure + * on cold boot with the standard debouncing timing. * * http://thread.gmane.org/gmane.linux.ide/34098 * - * Debounce with hotplug timing and request follow-up SRST. + * And bz#12176 reports that hardreset simply doesn't work on nf2. + * Give up on it and just don't do hardreset. */ static struct ata_port_operations nv_nf2_ops = { - .inherits = &nv_common_ops, + .inherits = &nv_generic_ops, .freeze = nv_nf2_freeze, .thaw = nv_nf2_thaw, - .hardreset = nv_noclassify_hardreset, }; /* For initial probing after boot and hot plugging, hardreset mostly |