diff options
| author | Sabrina Dubroca <sd@queasysnail.net> | 2018-09-12 17:44:41 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-09-13 12:03:47 -0700 |
| commit | 7cba09c6d5bc73ebbd25a353742d9ddb7a713b95 (patch) | |
| tree | e29dc6d8d637fd36f906016dfa30aa8ee4365457 /net/tls | |
| parent | f0e0d04413fcce9bc76388839099aee93cd0d33b (diff) | |
| download | linux-rpi3-7cba09c6d5bc73ebbd25a353742d9ddb7a713b95.tar.gz linux-rpi3-7cba09c6d5bc73ebbd25a353742d9ddb7a713b95.tar.bz2 linux-rpi3-7cba09c6d5bc73ebbd25a353742d9ddb7a713b95.zip | |
tls: don't copy the key out of tls12_crypto_info_aes_gcm_128
There's no need to copy the key to an on-stack buffer before calling
crypto_aead_setkey().
Fixes: 3c4d7559159b ("tls: kernel TLS support")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tls')
| -rw-r--r-- | net/tls/tls_sw.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c index e28a6ff25d96..f29b7c49cbf2 100644 --- a/net/tls/tls_sw.c +++ b/net/tls/tls_sw.c @@ -1136,7 +1136,6 @@ void tls_sw_free_resources_rx(struct sock *sk) int tls_set_sw_offload(struct sock *sk, struct tls_context *ctx, int tx) { - char keyval[TLS_CIPHER_AES_GCM_128_KEY_SIZE]; struct tls_crypto_info *crypto_info; struct tls12_crypto_info_aes_gcm_128 *gcm_128_info; struct tls_sw_context_tx *sw_ctx_tx = NULL; @@ -1265,9 +1264,7 @@ int tls_set_sw_offload(struct sock *sk, struct tls_context *ctx, int tx) ctx->push_pending_record = tls_sw_push_pending_record; - memcpy(keyval, gcm_128_info->key, TLS_CIPHER_AES_GCM_128_KEY_SIZE); - - rc = crypto_aead_setkey(*aead, keyval, + rc = crypto_aead_setkey(*aead, gcm_128_info->key, TLS_CIPHER_AES_GCM_128_KEY_SIZE); if (rc) goto free_aead; |