diff options
| author | Jia-Ju Bai <baijiaju1990@163.com> | 2017-05-31 15:08:25 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-06-01 14:49:47 -0400 |
| commit | 93818da5eed63fbc17b64080406ea53b86b23309 (patch) | |
| tree | ffe9549d810ab6446a47219fd4ee7d0a7b1979fe /drivers/isdn | |
| parent | 35cf2845563c1aaa01d27bd34d64795c4ae72700 (diff) | |
| download | linux-rpi-93818da5eed63fbc17b64080406ea53b86b23309.tar.gz linux-rpi-93818da5eed63fbc17b64080406ea53b86b23309.tar.bz2 linux-rpi-93818da5eed63fbc17b64080406ea53b86b23309.zip | |
mISDN: Fix a sleep-in-atomic bug
The driver may sleep under a read spin lock, and the function call path is:
send_socklist (acquire the lock by read_lock)
skb_copy(GFP_KERNEL) --> may sleep
To fix it, the "GFP_KERNEL" is replaced with "GFP_ATOMIC".
Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/isdn')
| -rw-r--r-- | drivers/isdn/mISDN/stack.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/isdn/mISDN/stack.c b/drivers/isdn/mISDN/stack.c index 8b7faea2ddf8..422dced7c90a 100644 --- a/drivers/isdn/mISDN/stack.c +++ b/drivers/isdn/mISDN/stack.c @@ -75,7 +75,7 @@ send_socklist(struct mISDN_sock_list *sl, struct sk_buff *skb) if (sk->sk_state != MISDN_BOUND) continue; if (!cskb) - cskb = skb_copy(skb, GFP_KERNEL); + cskb = skb_copy(skb, GFP_ATOMIC); if (!cskb) { printk(KERN_WARNING "%s no skb\n", __func__); break; |