diff options
author | Paolo Abeni <pabeni@redhat.com> | 2022-04-14 15:08:16 +0200 |
---|---|---|
committer | Paolo Abeni <pabeni@redhat.com> | 2022-04-14 15:08:16 +0200 |
commit | caf968b483351d8825e68b06d77de5eb618aeb64 (patch) | |
tree | 5718718ae3dd8cfaf28fd56d09b23f86fd343751 /drivers/irqchip/irq-gic-v3-its.c | |
parent | 9386ebccfc599de5578a278ffb16d90cc696969a (diff) | |
parent | 171cfae6b78c3b73d8cd3d405a63e38f15f363f2 (diff) | |
download | linux-rpi-caf968b483351d8825e68b06d77de5eb618aeb64.tar.gz linux-rpi-caf968b483351d8825e68b06d77de5eb618aeb64.tar.bz2 linux-rpi-caf968b483351d8825e68b06d77de5eb618aeb64.zip |
Merge branch 'rndis_host-handle-bogus-mac-addresses-in-zte-rndis-devices'
Lech Perczak says:
====================
rndis_host: handle bogus MAC addresses in ZTE RNDIS devices
When porting support of ZTE MF286R to OpenWrt [1], it was discovered,
that its built-in LTE modem fails to adjust its target MAC address,
when a random MAC address is assigned to the interface, due to detection of
"locally-administered address" bit. This leads to dropping of ingress
trafficat the host. The modem uses RNDIS as its primary interface,
with some variants exposing both of them simultaneously.
Then it was discovered, that cdc_ether driver contains a fixup for that
exact issue, also appearing on CDC ECM interfaces.
I discussed how to proceed with that with Bjørn Mork at OpenWrt forum [3],
with the first approach would be to trust the locally-administered MAC
again, and add a quirk for the problematic ZTE devices, as suggested by
Kristian Evensen. before [4], but reusing the fixup from cdc_ether looks
like a safer and more generic solution.
Finally, according to Bjørn's suggestion. limit the scope of bogus MAC
addressdetection to ZTE devices, the same way as it is done in cdc_ether,
as this trait wasn't really observed outside of ZTE devices.
Do that for both flavours of RNDIS devices, with interface classes
02/02/ff and e0/01/03, as both types are reported by different modems.
[1] https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=7ac8da00609f42b8aba74b7efc6b0d055b7cef3e
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bfe9b9d2df669a57a95d641ed46eb018e204c6ce
[3] https://forum.openwrt.org/t/problem-with-modem-in-zte-mf286r/120988
[4] https://lore.kernel.org/all/CAKfDRXhDp3heiD75Lat7cr1JmY-kaJ-MS0tt7QXX=s8RFjbpUQ@mail.gmail.com/T/
Cc: Bjørn Mork <bjorn@mork.no>
Cc: Kristian Evensen <kristian.evensen@gmail.com>
Cc: Oliver Neukum <oliver@neukum.org>
v3: Fixed wrong identifier commit description and whitespace in patch 2.
v2: ensure that MAC fixup is applied to all Ethernet frames in RNDIS
batch, by introducing a driver flag, and integrating the fixup inside
rndis_rx_fixup().
====================
Link: https://lore.kernel.org/r/20220413014416.2306843-1-lech.perczak@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'drivers/irqchip/irq-gic-v3-its.c')
0 files changed, 0 insertions, 0 deletions