summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBryan Wu <cooloney@kernel.org>2008-05-31 16:10:04 +0800
committerBryan Wu <cooloney@kernel.org>2008-05-31 16:10:04 +0800
commita4ed1e41a734d77c9a83a88a8736e19b68e6a2a0 (patch)
treed12b5607a64d198202af9acc0747d9c8dae98583
parenta70ce072b3883e431575449f3e294c27235590e5 (diff)
downloadlinux-rpi-a4ed1e41a734d77c9a83a88a8736e19b68e6a2a0.tar.gz
linux-rpi-a4ed1e41a734d77c9a83a88a8736e19b68e6a2a0.tar.bz2
linux-rpi-a4ed1e41a734d77c9a83a88a8736e19b68e6a2a0.zip
8250 Serial Driver: revert extra IRQ flag definition patch
As Russell pointed out, original patch will break some serial configurations because of the dependency of the <asm/serial.h> header file. Revert it first and try to find out other solution later Cc: Javier Herrero <jherrero@hvsistemas.es> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> Cc: Russell King <rmk+lkml@arm.linux.org.uk> Signed-off-by: Bryan Wu <cooloney@kernel.org>
-rw-r--r--drivers/serial/8250.c4
-rw-r--r--drivers/serial/8250.h5
2 files changed, 1 insertions, 8 deletions
diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
index 1400ea6a2491..1bc00b721e9d 100644
--- a/drivers/serial/8250.c
+++ b/drivers/serial/8250.c
@@ -43,7 +43,6 @@
#include <asm/io.h>
#include <asm/irq.h>
-#include <asm/serial.h>
#include "8250.h"
@@ -93,6 +92,7 @@ static unsigned int nr_uarts = CONFIG_SERIAL_8250_RUNTIME_UARTS;
*/
#define CONFIG_HUB6 1
+#include <asm/serial.h>
/*
* SERIAL_PORT_DFNS tells us about built-in ports that have no
* standard enumeration mechanism. Platforms that can find all
@@ -1547,8 +1547,6 @@ static int serial_link_irq_chain(struct uart_8250_port *up)
i->head = &up->list;
spin_unlock_irq(&i->lock);
- irq_flags |= SERIAL_EXTRA_IRQ_FLAGS;
-
ret = request_irq(up->port.irq, serial8250_interrupt,
irq_flags, "serial", i);
if (ret < 0)
diff --git a/drivers/serial/8250.h b/drivers/serial/8250.h
index a10a40cc0d9e..91bd28f2bb47 100644
--- a/drivers/serial/8250.h
+++ b/drivers/serial/8250.h
@@ -78,8 +78,3 @@ struct serial8250_config {
#else
#define ALPHA_KLUDGE_MCR 0
#endif
-
-#ifndef SERIAL_EXTRA_IRQ_FLAGS
-#define SERIAL_EXTRA_IRQ_FLAGS 0
-#endif
-