summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJens Axboe <axboe@kernel.dk>2023-04-12 12:07:36 -0600
committerJens Axboe <axboe@kernel.dk>2023-04-12 12:07:36 -0600
commit27a67079c0e548d5c3232c40951517cfa630fe51 (patch)
treebccb34ab7a3cd613af685f1f43ad669aa40a6980
parent360cd42c4e95ff06d8d7b0a54e42236c7e7c187f (diff)
downloadlinux-rpi-27a67079c0e548d5c3232c40951517cfa630fe51.tar.gz
linux-rpi-27a67079c0e548d5c3232c40951517cfa630fe51.tar.bz2
linux-rpi-27a67079c0e548d5c3232c40951517cfa630fe51.zip
io_uring/uring_cmd: take advantage of completion batching
We know now what the completion context is for the uring_cmd completion handling, so use that to have io_req_task_complete() decide what the best way to complete the request is. This allows batching of the posted completions if we have multiple pending, rather than always doing them one-by-one. Signed-off-by: Jens Axboe <axboe@kernel.dk>
-rw-r--r--io_uring/uring_cmd.c10
1 files changed, 7 insertions, 3 deletions
diff --git a/io_uring/uring_cmd.c b/io_uring/uring_cmd.c
index f7a96bc76ea1..5113c9a48583 100644
--- a/io_uring/uring_cmd.c
+++ b/io_uring/uring_cmd.c
@@ -54,11 +54,15 @@ void io_uring_cmd_done(struct io_uring_cmd *ioucmd, ssize_t ret, ssize_t res2,
io_req_set_res(req, ret, 0);
if (req->ctx->flags & IORING_SETUP_CQE32)
io_req_set_cqe32_extra(req, res2, 0);
- if (req->ctx->flags & IORING_SETUP_IOPOLL)
+ if (req->ctx->flags & IORING_SETUP_IOPOLL) {
/* order with io_iopoll_req_issued() checking ->iopoll_complete */
smp_store_release(&req->iopoll_completed, 1);
- else
- io_req_complete_post(req, issue_flags);
+ } else {
+ struct io_tw_state ts = {
+ .locked = !(issue_flags & IO_URING_F_UNLOCKED),
+ };
+ io_req_task_complete(req, &ts);
+ }
}
EXPORT_SYMBOL_GPL(io_uring_cmd_done);