summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorByungchul Park <byungchul.park@lge.com>2017-09-06 14:25:54 +0800
committerJens Axboe <axboe@kernel.dk>2017-09-06 08:17:33 -0600
commit09b3efec81def807fb225359e34a8e72866dd9c4 (patch)
treec5137d64a6cdb23308d1f8bedec7e97c37b570bc
parent69daf03adef5f7bc13e0ac86b4b8007df1767aab (diff)
downloadlinux-rpi-09b3efec81def807fb225359e34a8e72866dd9c4.tar.gz
linux-rpi-09b3efec81def807fb225359e34a8e72866dd9c4.tar.bz2
linux-rpi-09b3efec81def807fb225359e34a8e72866dd9c4.zip
bcache: Don't reinvent the wheel but use existing llist API
Although llist provides proper APIs, they are not used. Make them used. Signed-off-by: Byungchul Park <byungchul.park@lge.com> Acked-by: Coly Li <colyli@suse.de> Signed-off-by: Jens Axboe <axboe@kernel.dk>
-rw-r--r--drivers/md/bcache/closure.c15
1 files changed, 2 insertions, 13 deletions
diff --git a/drivers/md/bcache/closure.c b/drivers/md/bcache/closure.c
index 864e673aec39..7d5286b05036 100644
--- a/drivers/md/bcache/closure.c
+++ b/drivers/md/bcache/closure.c
@@ -70,21 +70,10 @@ void __closure_wake_up(struct closure_waitlist *wait_list)
list = llist_del_all(&wait_list->list);
/* We first reverse the list to preserve FIFO ordering and fairness */
-
- while (list) {
- struct llist_node *t = list;
- list = llist_next(list);
-
- t->next = reverse;
- reverse = t;
- }
+ reverse = llist_reverse_order(list);
/* Then do the wakeups */
-
- while (reverse) {
- cl = container_of(reverse, struct closure, list);
- reverse = llist_next(reverse);
-
+ llist_for_each_entry(cl, reverse, list) {
closure_set_waiting(cl, 0);
closure_sub(cl, CLOSURE_WAITING + 1);
}