From 835d89e92fa77b6a1effea3db80202e1ffec413a Mon Sep 17 00:00:00 2001 From: Christophe JAILLET Date: Fri, 14 Apr 2017 08:08:03 +0200 Subject: md-cluster: Fix a memleak in an error handling path We know that 'bm_lockres' is NULL here, so 'lockres_free(bm_lockres)' is a no-op. According to resource handling in case of error a few lines below, it is likely that 'bitmap_free(bitmap)' was expected instead. Fixes: b98938d16a10 ("md-cluster: introduce cluster_check_sync_size") Signed-off-by: Christophe JAILLET Reviewed-by: Guoqing Jiang Signed-off-by: Shaohua Li --- drivers/md/md-cluster.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/md-cluster.c b/drivers/md/md-cluster.c index b21ef58819f6..7299ce2f08a8 100644 --- a/drivers/md/md-cluster.c +++ b/drivers/md/md-cluster.c @@ -1127,7 +1127,7 @@ int cluster_check_sync_size(struct mddev *mddev) bm_lockres = lockres_init(mddev, str, NULL, 1); if (!bm_lockres) { pr_err("md-cluster: Cannot initialize %s\n", str); - lockres_free(bm_lockres); + bitmap_free(bitmap); return -1; } bm_lockres->flags |= DLM_LKF_NOQUEUE; -- cgit v1.2.3