summaryrefslogtreecommitdiff
path: root/drivers/atm/solos-pci.c
AgeCommit message (Collapse)AuthorFilesLines
2009-11-18drivers/atm/solos-pci.c: fix warning/bug, clean up codeAndrew Morton1-13/+16
drivers/atm/solos-pci.c: In function 'flash_upgrade': drivers/atm/solos-pci.c:528: warning: 'fw_name' may be used uninitialized in this function Cc: Chas Williams <chas@cmf.nrl.navy.mil> Cc: David Woodhouse <David.Woodhouse@intel.com> Cc: Nathan Williams <nathan@traverse.com.au> Cc: David S. Miller <davem@davemloft.net> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Acked-By: David Woodhouse <David.Woodhouse@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
2009-11-10solos-pci: declare MODULE_FIRMWAREBen Hutchings1-0/+3
Signed-off-by: Ben Hutchings <ben@decadent.org.uk> Signed-off-by: David S. Miller <davem@davemloft.net>
2009-09-22Merge branch 'master' of git://git.infradead.org/users/dwmw2/solos-2.6David S. Miller1-9/+66
2009-07-27drivers/atm: Correct redundant testJulia Lawall1-1/+1
str has already been tested. It seems that this test should be on the recently returned value snr. A simplified version of the semantic match that finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @r exists@ local idexpression x; expression E; @@ if (x == NULL || ...) { ... when forall return ...; } ... when != \(x=E\|x--\|x++\|--x\|++x\|x-=E\|x+=E\|x|=E\|x&=E\|&x\) ( *x == NULL | *x != NULL ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: David S. Miller <davem@davemloft.net>
2009-04-13Replace all DMA_nBIT_MASK macro with DMA_BIT_MASK(n)Yang Hongyang1-1/+1
This is the second go through of the old DMA_nBIT_MASK macro,and there're not so many of them left,so I put them into one patch.I hope this is the last round. After this the definition of the old DMA_nBIT_MASK macro could be removed. Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com> Cc: Russell King <rmk@arm.linux.org.uk> Cc: Tony Lindgren <tony@atomide.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: James Bottomley <James.Bottomley@HansenPartnership.com> Cc: Greg KH <greg@kroah.com> Cc: Takashi Iwai <tiwai@suse.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-03-25solos: Check for rogue received packetsNathan Williams1-0/+4
Sometimes there can be received packets with the size field set to 0xFFFF. This seems to only occur after an FPGA or firmware upgrade. This patch discards packets with an invalid size. Signed-off-by: Nathan Williams <nathan@traverse.com.au> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-03-25solos: support new FPGA RAM layoutNathan Williams1-9/+62
Buffer sizes have been changed to 2048 bytes. Flash upgrades use a dedicated RAM block. Add support for daughterboard. Signed-off-by: Nathan Williams <nathan@traverse.com.au> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-03-21Merge branch 'master' of git://git.infradead.org/~dwmw2/solos-2.6David S. Miller1-160/+664
2009-03-17solos: Disable DMA until we have an FPGA update with it actually implemented.David Woodhouse1-1/+1
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-03-17solos: Automatically determine number of portsNathan Williams1-1/+2
Signed-off-by: Nathan Williams <nathan@traverse.com.au> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-03-17solos: Reset device on unload, free pending skbsDavid Woodhouse1-1/+29
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-02-08drivers/atm: introduce missing kfreeJulia Lawall1-0/+1
Error handling code following a kmalloc should free the allocated data. The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @r exists@ local idexpression x; statement S; expression E; identifier f,l; position p1,p2; expression *ptr != NULL; @@ ( if ((x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...)) == NULL) S | x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...); ... if (x == NULL) S ) <... when != x when != if (...) { <+...x...+> } x->f = E ...> ( return \(0\|<+...x...+>\|ptr\); | return@p2 ...; ) @script:python@ p1 << r.p1; p2 << r.p2; @@ print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: David S. Miller <davem@davemloft.net>
2009-01-30solos: Swap upstream/downstream rates in status packet, clean up some moreDavid Woodhouse1-26/+25
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-30solos: Set RX empty flag at startup only for !dma modeDavid Woodhouse1-2/+4
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-30solos: Don't clear config registers at startupDavid Woodhouse1-5/+1
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-30solos: Tidy up status interrupt handling, cope with 'ERROR' statusDavid Woodhouse1-4/+13
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-30solos: Add 'reset' module parameter to reset the DSL chips on loadDavid Woodhouse1-0/+10
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-29solos: Remove debugging, commented-out test codeDavid Woodhouse1-49/+3
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-29solos: Clean up handling of card->tx_mask a littleDavid Woodhouse1-25/+28
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-29solos: Fix various bugs in status packet handlingDavid Woodhouse1-21/+28
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-29solos: Remove superfluous wait_queue_head_t from struct solos_paramDavid Woodhouse1-1/+0
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-29solos: Remove IRQF_DISABLED, don't frob IRQ enable on the FPGA in solos_irq()David Woodhouse1-5/+1
Neither of these are necessary. Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-29solos: Remove unused loopback debug stuffDavid Woodhouse1-23/+0
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-29solos: Tidy up tx_mask handling for ports which need TXDavid Woodhouse1-7/+13
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-29solos: Tidy up DMA handling a little. Still untestedDavid Woodhouse1-42/+53
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-28solos: First attempt at DMA supportDavid Woodhouse1-28/+90
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-28solos: Remove parameter group from sysfs on ATM dev deregisterDavid Woodhouse1-0/+2
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-28solos: Fix under-allocation of skb size for get/set parametersDavid Woodhouse1-2/+2
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-28solos: Add SNR and Attn to status packet, fix oops on loadDavid Woodhouse1-7/+23
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-27solos: Reject non-AAL5 connections.... for nowDavid Woodhouse1-0/+6
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-27solos: Kill existing connections on link down eventDavid Woodhouse1-2/+28
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-27solos: Handle new line status change packets, hook up to ATM layer infoDavid Woodhouse1-1/+92
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-27solos: Add initial list of parametersDavid Woodhouse1-6/+24
I don't much like the trick with multiple inclusions of solos-attrlist.c but don't really see a saner way to do it without repeating the list. Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-27solos: Handle attribute show/store in kernel more sanelyDavid Woodhouse1-0/+187
There are still a _lot_ of attributes, but for at least the basic ones we want to be able to get/set them from the kernel. Especially the ones we want to inform the ATM core about (link state, speed). Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-27solos: Kill global 'opens' count.David Woodhouse1-10/+0
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-27solos: Clean up firmware loading codeDavid Woodhouse1-136/+73
We no longer try to load firmware while the ATM is up and running. However, this means that we _do_ make init_module() wait for it, and it takes a long time for now (since we're using ultra-conservative code in the FPGA for that too). The inner loop which uses swahb32p() was by Simon Farnsworth. Simon has patches which migrate us to request_firmware_nowait(), for which we'll actually need to take down the ATM devices, do the upgrade, then reregister them. Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-27solos: FPGA and firmware update support.Simon Farnsworth1-2/+169
This is just a straight pull in of changes, syncing us up to 0.07 from openadsl.sf.net Signed-off-by: Nathan Williams <nathan@traverse.com.au> Signed-off-by: Simon Farnsworth <simon@farnz.org.uk> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-27solos: Slight debugging improvementsSimon Farnsworth1-1/+2
Print a message if pskb_expand_head fails. Make atmdebug writable by root, so that you can turn printing of data sent to and received from the card on and off at runtime - useful for tracking corruption. Signed-off-by: Simon Farnsworth <simon@farnz.org.uk> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2009-01-27solos: Fix length header in FPGA transfersDavid Woodhouse1-4/+7
The length field shouldn't ever include the size of the header itself. This fixes the problem that some people were seeing with 1500-byte packets. Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
2008-12-26atm: Driver for Solos PCI ADSL2+ card.David Woodhouse1-0/+790
This adds basic support for the 'Solos' PCI ADSL2+ cards being developed by Traverse Technologies and Xrio Ltd: http://www.traverse.com.au/productview.php?product_id=116 Signed-off-by: Nathan Williams <nathan@traverse.com.au> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>