diff options
| author | Seung-Woo Kim <sw0312.kim@samsung.com> | 2016-12-12 17:21:40 +0900 |
|---|---|---|
| committer | Seung-Woo Kim <sw0312.kim@samsung.com> | 2016-12-12 17:40:23 +0900 |
| commit | 7b0cc6610aaa548653da3fcdd69da70961f6c0dc (patch) | |
| tree | 0f81b66d00988856c688575bc50a2794c34b502f | |
| parent | eed519ed3f25a2f54edc77a996e1a3a94a085582 (diff) | |
| download | linux-exynos-7b0cc6610aaa548653da3fcdd69da70961f6c0dc.tar.gz linux-exynos-7b0cc6610aaa548653da3fcdd69da70961f6c0dc.tar.bz2 linux-exynos-7b0cc6610aaa548653da3fcdd69da70961f6c0dc.zip | |
Smack: ignore private inode for file functionssubmit/tizen/20161213.001106accepted/tizen/wearable/20161214.014056accepted/tizen/tv/20161214.014040accepted/tizen/mobile/20161214.014022accepted/tizen/ivi/20161214.014117accepted/tizen/common/20161213.164744
The access to fd from anon_inode is always failed because there is
no set xattr operations. So this patch fixes to ignore private
inode including anon_inode for file functions.
It was only ignored for smack_file_receive() to share dma-buf fd,
but dma-buf has other functions like ioctl and mmap.
Reference: https://lkml.org/lkml/2015/4/17/16
Change-Id: I1c6b93107c17e1ca3d96360c5cb8ec18a29ba45e
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
| -rw-r--r-- | security/smack/smack_lsm.c | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c index 793c23a43b4f..38135fc9b802 100644 --- a/security/smack/smack_lsm.c +++ b/security/smack/smack_lsm.c @@ -1632,6 +1632,9 @@ static int smack_file_ioctl(struct file *file, unsigned int cmd, struct smk_audit_info ad; struct inode *inode = file_inode(file); + if (unlikely(IS_PRIVATE(inode))) + return 0; + smk_ad_init(&ad, __func__, LSM_AUDIT_DATA_PATH); smk_ad_setfield_u_fs_path(&ad, file->f_path); @@ -1661,6 +1664,9 @@ static int smack_file_lock(struct file *file, unsigned int cmd) int rc; struct inode *inode = file_inode(file); + if (unlikely(IS_PRIVATE(inode))) + return 0; + smk_ad_init(&ad, __func__, LSM_AUDIT_DATA_PATH); smk_ad_setfield_u_fs_path(&ad, file->f_path); rc = smk_curacc(smk_of_inode(inode), MAY_LOCK, &ad); @@ -1687,6 +1693,9 @@ static int smack_file_fcntl(struct file *file, unsigned int cmd, int rc = 0; struct inode *inode = file_inode(file); + if (unlikely(IS_PRIVATE(inode))) + return 0; + switch (cmd) { case F_GETLK: break; @@ -1739,6 +1748,9 @@ static int smack_mmap_file(struct file *file, if (file == NULL) return 0; + if (unlikely(IS_PRIVATE(file_inode(file)))) + return 0; + isp = file_inode(file)->i_security; if (isp->smk_mmap == NULL) return 0; |