diff options
| author | Darrick J. Wong <djwong@us.ibm.com> | 2010-11-19 09:56:44 -0500 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2010-11-19 09:56:44 -0500 |
| commit | 5a9ae68a349aa076bc8557ee2fcf865574459282 (patch) | |
| tree | 484c26f74f13a0c5962ac634c90462d98dea8e1a /tools | |
| parent | 0587aa3d11f9769a301b21bff2c3ed8365606b8d (diff) | |
| download | linux-3.10-5a9ae68a349aa076bc8557ee2fcf865574459282.tar.gz linux-3.10-5a9ae68a349aa076bc8557ee2fcf865574459282.tar.bz2 linux-3.10-5a9ae68a349aa076bc8557ee2fcf865574459282.zip | |
ext4: ext4_fill_super shouldn't return 0 on corruption
At the start of ext4_fill_super, ret is set to -EINVAL, and any failure path
out of that function returns ret. However, the generic_check_addressable
clause sets ret = 0 (if it passes), which means that a subsequent failure (e.g.
a group checksum error) returns 0 even though the mount should fail. This
causes vfs_kern_mount in turn to think that the mount succeeded, leading to an
oops.
A simple fix is to avoid using ret for the generic_check_addressable check,
which was last changed in commit 30ca22c70e3ef0a96ff84de69cd7e8561b416cb2.
Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions