diff options
author | Takashi Iwai <tiwai@suse.de> | 2013-10-14 16:02:15 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-11-04 04:31:06 -0800 |
commit | 1f931f65de9d04daf024eeb4dd6a8fe93b7a8e91 (patch) | |
tree | 5459f52deba026588dd75f9ffb3280d264f50240 /sound/usb/usx2y | |
parent | 7ed008638ee15991b79d8867d382e141fee89a69 (diff) | |
download | linux-3.10-1f931f65de9d04daf024eeb4dd6a8fe93b7a8e91.tar.gz linux-3.10-1f931f65de9d04daf024eeb4dd6a8fe93b7a8e91.tar.bz2 linux-3.10-1f931f65de9d04daf024eeb4dd6a8fe93b7a8e91.zip |
ALSA: us122l: Fix pcm_usb_stream mmapping regression
commit ac536a848a1643e4b87e8fbd376a63091afc2ccc upstream.
The pcm_usb_stream plugin requires the mremap explicitly for the read
buffer, as it expands itself once after reading the required size.
But the commit [314e51b9: mm: kill vma flag VM_RESERVED and
mm->reserved_vm counter] converted blindly to a combination of
VM_DONTEXPAND | VM_DONTDUMP like other normal drivers, and this
resulted in the failure of mremap().
For fixing this regression, we need to remove VM_DONTEXPAND for the
read-buffer mmap.
Reported-and-tested-by: James Miller <jamesstewartmiller@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'sound/usb/usx2y')
-rw-r--r-- | sound/usb/usx2y/us122l.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/sound/usb/usx2y/us122l.c b/sound/usb/usx2y/us122l.c index d0323a693ba..999550bbad4 100644 --- a/sound/usb/usx2y/us122l.c +++ b/sound/usb/usx2y/us122l.c @@ -262,7 +262,9 @@ static int usb_stream_hwdep_mmap(struct snd_hwdep *hw, } area->vm_ops = &usb_stream_hwdep_vm_ops; - area->vm_flags |= VM_DONTEXPAND | VM_DONTDUMP; + area->vm_flags |= VM_DONTDUMP; + if (!read) + area->vm_flags |= VM_DONTEXPAND; area->vm_private_data = us122l; atomic_inc(&us122l->mmap_count); out: |