diff options
| author | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2011-03-16 18:18:53 +0000 |
|---|---|---|
| committer | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2011-03-18 10:51:42 +0000 |
| commit | b1a56b331aec59be04f25ac99694d855d591c539 (patch) | |
| tree | 8b4df0abdab4c07c84ff837385980aa39d93eb24 /sound/soc | |
| parent | 2a3887f7015b547ad8195391d1f6c2136062be32 (diff) | |
| download | linux-3.10-b1a56b331aec59be04f25ac99694d855d591c539.tar.gz linux-3.10-b1a56b331aec59be04f25ac99694d855d591c539.tar.bz2 linux-3.10-b1a56b331aec59be04f25ac99694d855d591c539.zip | |
ASoC: Remove bogus check for register validity in debugfs write
Since not all registers need to be cached and the cache is entirely
optional anyway we shouldn't be checking that a register is in the
cached range. If the register is invalid then the actual I/O code
can determine that and report an error.
Similarly, the step size can and should be enforced by the lower level
code if it's important.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Diffstat (limited to 'sound/soc')
| -rw-r--r-- | sound/soc/soc-core.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 17efacdb248..4dda58926bc 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -259,8 +259,6 @@ static ssize_t codec_reg_write_file(struct file *file, while (*start == ' ') start++; reg = simple_strtoul(start, &start, 16); - if ((reg >= codec->driver->reg_cache_size) || (reg % step)) - return -EINVAL; while (*start == ' ') start++; if (strict_strtoul(start, 16, &value)) |