diff options
| author | NeilBrown <neilb@suse.de> | 2010-03-16 15:14:51 +1100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-05-21 09:37:29 -0700 |
| commit | db1afffab0b5d9f6d31f8f4bea44c9cb3bc59351 (patch) | |
| tree | 5ba8fd7a5018c0772d999b8c3aa945c0efb929e0 /security | |
| parent | dd336c554d8926c3348a2d5f2a5ef5597f6d1a06 (diff) | |
| download | linux-3.10-db1afffab0b5d9f6d31f8f4bea44c9cb3bc59351.tar.gz linux-3.10-db1afffab0b5d9f6d31f8f4bea44c9cb3bc59351.tar.bz2 linux-3.10-db1afffab0b5d9f6d31f8f4bea44c9cb3bc59351.zip | |
kref: remove kref_set
Of the three uses of kref_set in the kernel:
One really should be kref_put as the code is letting go of a
reference,
Two really should be kref_init because the kref is being
initialised.
This suggests that making kref_set available encourages bad code.
So fix the three uses and remove kref_set completely.
Signed-off-by: NeilBrown <neilb@suse.de>
Acked-by: Mimi Zohar <zohar@us.ibm.com>
Acked-by: Serge Hallyn <serue@us.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'security')
| -rw-r--r-- | security/integrity/ima/ima_iint.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/security/integrity/ima/ima_iint.c b/security/integrity/ima/ima_iint.c index 2dc2d659414..7625b85c227 100644 --- a/security/integrity/ima/ima_iint.c +++ b/security/integrity/ima/ima_iint.c @@ -94,7 +94,7 @@ void iint_free(struct kref *kref) iint->opencount); iint->opencount = 0; } - kref_set(&iint->refcount, 1); + kref_init(&iint->refcount); kmem_cache_free(iint_cache, iint); } @@ -133,7 +133,7 @@ static void init_once(void *foo) iint->readcount = 0; iint->writecount = 0; iint->opencount = 0; - kref_set(&iint->refcount, 1); + kref_init(&iint->refcount); } static int __init ima_iintcache_init(void) |