summaryrefslogtreecommitdiff
path: root/security
diff options
context:
space:
mode:
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>2011-10-11 14:05:08 +0900
committerJames Morris <jmorris@namei.org>2011-10-12 12:15:18 +1100
commite2b8b25a6795488eba7bb757706b3ac725c31fac (patch)
treef77e43a01891938e8c83b56d2c249a725923b9ec /security
parente00fb3f7af111d1b3252f7d622213d2e22be65f5 (diff)
downloadlinux-3.10-e2b8b25a6795488eba7bb757706b3ac725c31fac.tar.gz
linux-3.10-e2b8b25a6795488eba7bb757706b3ac725c31fac.tar.bz2
linux-3.10-e2b8b25a6795488eba7bb757706b3ac725c31fac.zip
TOMOYO: Remove redundant tasklist_lock.
rcu_read_lock() is sufficient for calling find_task_by_pid_ns()/find_task_by_vpid(). Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: James Morris <jmorris@namei.org>
Diffstat (limited to 'security')
-rw-r--r--security/tomoyo/common.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/security/tomoyo/common.c b/security/tomoyo/common.c
index 2e2802060ee..365f3bddee7 100644
--- a/security/tomoyo/common.c
+++ b/security/tomoyo/common.c
@@ -984,14 +984,12 @@ static bool tomoyo_select_domain(struct tomoyo_io_buffer *head,
(global_pid = true, sscanf(data, "global-pid=%u", &pid) == 1)) {
struct task_struct *p;
rcu_read_lock();
- read_lock(&tasklist_lock);
if (global_pid)
p = find_task_by_pid_ns(pid, &init_pid_ns);
else
p = find_task_by_vpid(pid);
if (p)
domain = tomoyo_real_domain(p);
- read_unlock(&tasklist_lock);
rcu_read_unlock();
} else if (!strncmp(data, "domain=", 7)) {
if (tomoyo_domain_def(data + 7))
@@ -1664,14 +1662,12 @@ static void tomoyo_read_pid(struct tomoyo_io_buffer *head)
global_pid = true;
pid = (unsigned int) simple_strtoul(buf, NULL, 10);
rcu_read_lock();
- read_lock(&tasklist_lock);
if (global_pid)
p = find_task_by_pid_ns(pid, &init_pid_ns);
else
p = find_task_by_vpid(pid);
if (p)
domain = tomoyo_real_domain(p);
- read_unlock(&tasklist_lock);
rcu_read_unlock();
if (!domain)
return;