diff options
| author | Nick Bowler <nbowler@elliptictech.com> | 2011-11-08 12:12:44 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-11-09 15:55:53 -0500 |
| commit | 069294e813ed5f27f82613b027609bcda5f1b914 (patch) | |
| tree | 4c6254008c1fc04e09b48c618e30622e5aeefc0a /net | |
| parent | fecc73519439361eab21fb3cebec504672ef0e03 (diff) | |
| download | linux-3.10-069294e813ed5f27f82613b027609bcda5f1b914.tar.gz linux-3.10-069294e813ed5f27f82613b027609bcda5f1b914.tar.bz2 linux-3.10-069294e813ed5f27f82613b027609bcda5f1b914.zip | |
ah: Correctly pass error codes in ahash output callback.
The AH4/6 ahash output callbacks pass nexthdr to xfrm_output_resume
instead of the error code. This appears to be a copy+paste error from
the input case, where nexthdr is expected. This causes the driver to
continuously add AH headers to the datagram until either an allocation
fails and the packet is dropped or the ahash driver hits a synchronous
fallback and the resulting monstrosity is transmitted.
Correct this issue by simply passing the error code unadulterated.
Signed-off-by: Nick Bowler <nbowler@elliptictech.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv4/ah4.c | 2 | ||||
| -rw-r--r-- | net/ipv6/ah6.c | 2 |
2 files changed, 0 insertions, 4 deletions
diff --git a/net/ipv4/ah4.c b/net/ipv4/ah4.c index c1f4154552f..33ca18603e3 100644 --- a/net/ipv4/ah4.c +++ b/net/ipv4/ah4.c @@ -136,8 +136,6 @@ static void ah_output_done(struct crypto_async_request *base, int err) memcpy(top_iph+1, iph+1, top_iph->ihl*4 - sizeof(struct iphdr)); } - err = ah->nexthdr; - kfree(AH_SKB_CB(skb)->tmp); xfrm_output_resume(skb, err); } diff --git a/net/ipv6/ah6.c b/net/ipv6/ah6.c index 2195ae65192..ede4d9d6cc2 100644 --- a/net/ipv6/ah6.c +++ b/net/ipv6/ah6.c @@ -324,8 +324,6 @@ static void ah6_output_done(struct crypto_async_request *base, int err) #endif } - err = ah->nexthdr; - kfree(AH_SKB_CB(skb)->tmp); xfrm_output_resume(skb, err); } |