summaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorEric Dumazet <eric.dumazet@gmail.com>2011-03-24 07:01:24 +0000
committerDavid S. Miller <davem@davemloft.net>2011-03-24 11:49:54 -0700
commitfcd13f42c9d6ab7b1024b9b7125a2e8db3cc00b2 (patch)
tree2c088856e18636a77077cea244e227453782910c /net
parent6f71d7927c9a9efb7d7e9e6d227d5e246a9c5bd7 (diff)
downloadlinux-3.10-fcd13f42c9d6ab7b1024b9b7125a2e8db3cc00b2.tar.gz
linux-3.10-fcd13f42c9d6ab7b1024b9b7125a2e8db3cc00b2.tar.bz2
linux-3.10-fcd13f42c9d6ab7b1024b9b7125a2e8db3cc00b2.zip
ipv4: fix fib metrics
Alessandro Suardi reported that we could not change route metrics : ip ro change default .... advmss 1400 This regression came with commit 9c150e82ac50 (Allocate fib metrics dynamically). fib_metrics is no longer an array, but a pointer to an array. Reported-by: Alessandro Suardi <alessandro.suardi@gmail.com> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Tested-by: Alessandro Suardi <alessandro.suardi@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/ipv4/fib_semantics.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c
index 622ac4c9502..75b9fb5d5d3 100644
--- a/net/ipv4/fib_semantics.c
+++ b/net/ipv4/fib_semantics.c
@@ -251,7 +251,7 @@ static struct fib_info *fib_find_info(const struct fib_info *nfi)
nfi->fib_prefsrc == fi->fib_prefsrc &&
nfi->fib_priority == fi->fib_priority &&
memcmp(nfi->fib_metrics, fi->fib_metrics,
- sizeof(fi->fib_metrics)) == 0 &&
+ sizeof(u32) * RTAX_MAX) == 0 &&
((nfi->fib_flags ^ fi->fib_flags) & ~RTNH_F_DEAD) == 0 &&
(nfi->fib_nhs == 0 || nh_comp(fi, nfi) == 0))
return fi;