summaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorAlex Elder <elder@dreamhost.com>2012-02-14 14:05:33 -0600
committerAlex Elder <elder@dreamhost.com>2012-03-22 10:47:50 -0500
commit963be4d7709f84d865f76d12d5b0ec7edad1c498 (patch)
tree798e98459427acc942228c42a69c3bc4ff3308bd /net
parent32eec68d2f233e8a6ae1cd326022f6862e2b9ce3 (diff)
downloadlinux-3.10-963be4d7709f84d865f76d12d5b0ec7edad1c498.tar.gz
linux-3.10-963be4d7709f84d865f76d12d5b0ec7edad1c498.tar.bz2
linux-3.10-963be4d7709f84d865f76d12d5b0ec7edad1c498.zip
libceph: move prepare_write_banner()
One of the arguments to prepare_write_connect() indicates whether it is being called immediately after a call to prepare_write_banner(). Move the prepare_write_banner() call inside prepare_write_connect(), and reinterpret (and rename) the "after_banner" argument so it indicates that prepare_write_connect() should *make* the call rather than should know it has already been made. This was split out from the next patch to highlight this change in logic. Signed-off-by: Alex Elder <elder@dreamhost.com> Signed-off-by: Sage Weil <sage@newdream.net>
Diffstat (limited to 'net')
-rw-r--r--net/ceph/messenger.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c
index 3917847ad8e..0665945b646 100644
--- a/net/ceph/messenger.c
+++ b/net/ceph/messenger.c
@@ -676,7 +676,7 @@ static void prepare_write_banner(struct ceph_messenger *msgr,
static int prepare_write_connect(struct ceph_messenger *msgr,
struct ceph_connection *con,
- int after_banner)
+ int include_banner)
{
unsigned global_seq = get_global_seq(con->msgr, 0);
int proto;
@@ -705,7 +705,9 @@ static int prepare_write_connect(struct ceph_messenger *msgr,
con->out_connect.protocol_version = cpu_to_le32(proto);
con->out_connect.flags = 0;
- if (!after_banner) {
+ if (include_banner)
+ prepare_write_banner(msgr, con);
+ else {
con->out_kvec_left = 0;
con->out_kvec_bytes = 0;
}
@@ -1846,7 +1848,6 @@ more:
/* open the socket first? */
if (con->sock == NULL) {
- prepare_write_banner(msgr, con);
prepare_write_connect(msgr, con, 1);
prepare_read_banner(con);
set_bit(CONNECTING, &con->state);