summaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorJesper Juhl <juhl-lkml@dif.dk>2005-06-18 23:00:15 -0700
committerDavid S. Miller <davem@davemloft.net>2005-06-18 23:00:15 -0700
commit93765d8a435fa021c4b7cd0521b7959239d7158a (patch)
tree05858c1b7f3c8bf069a2b45051af9d9db8e0804b /net
parent926d4b8122fb324de294a09a7d96d8af7cfc6861 (diff)
downloadlinux-3.10-93765d8a435fa021c4b7cd0521b7959239d7158a.tar.gz
linux-3.10-93765d8a435fa021c4b7cd0521b7959239d7158a.tar.bz2
linux-3.10-93765d8a435fa021c4b7cd0521b7959239d7158a.zip
[IPV4]: [3/4] signed vs unsigned cleanup in net/ipv4/raw.c
This patch changes the type of the local variable 'i' in raw_probe_proto_opt() from 'int' to 'unsigned int'. The only use of 'i' in this function is as a counter in a for() loop and subsequent index into the msg->msg_iov[] array. Since 'i' is compared in a loop to the unsigned variable msg->msg_iovlen gcc -W generates this warning : net/ipv4/raw.c:340: warning: comparison between signed and unsigned Changing 'i' to unsigned silences this warning and is safe since the array index can never be negative anyway, so unsigned int is the logical type to use for 'i' and also enables a larger msg_iov[] array (but I don't know if that will ever matter). Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/ipv4/raw.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c
index 1fcb23d3351..085a08ea5a5 100644
--- a/net/ipv4/raw.c
+++ b/net/ipv4/raw.c
@@ -332,7 +332,7 @@ static void raw_probe_proto_opt(struct flowi *fl, struct msghdr *msg)
u8 __user *type = NULL;
u8 __user *code = NULL;
int probed = 0;
- int i;
+ unsigned int i;
if (!msg->msg_iov)
return;