diff options
| author | Trond Myklebust <Trond.Myklebust@netapp.com> | 2009-03-11 14:38:00 -0400 |
|---|---|---|
| committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2009-03-11 14:38:00 -0400 |
| commit | 2a4919919a97911b0aa4b9f5ac1eab90ba87652b (patch) | |
| tree | c12eb42c34f0d0b79130ae93ebd56159e8366ee8 /net/sunrpc/clnt.c | |
| parent | 482f32e65d31cbf88d08306fa5d397cc945c3c26 (diff) | |
| download | linux-3.10-2a4919919a97911b0aa4b9f5ac1eab90ba87652b.tar.gz linux-3.10-2a4919919a97911b0aa4b9f5ac1eab90ba87652b.tar.bz2 linux-3.10-2a4919919a97911b0aa4b9f5ac1eab90ba87652b.zip | |
SUNRPC: Return EAGAIN instead of ENOTCONN when waking up xprt->pending
While we should definitely return socket errors to the task that is
currently trying to send data, there is no need to propagate the same error
to all the other tasks on xprt->pending. Doing so actually slows down
recovery, since it causes more than one tasks to attempt socket recovery.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'net/sunrpc/clnt.c')
| -rw-r--r-- | net/sunrpc/clnt.c | 15 |
1 files changed, 4 insertions, 11 deletions
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c index 145715b5311..5abab094441 100644 --- a/net/sunrpc/clnt.c +++ b/net/sunrpc/clnt.c @@ -1032,27 +1032,20 @@ call_connect_status(struct rpc_task *task) dprint_status(task); task->tk_status = 0; - if (status >= 0) { + if (status >= 0 || status == -EAGAIN) { clnt->cl_stats->netreconn++; task->tk_action = call_transmit; return; } - /* Something failed: remote service port may have changed */ - rpc_force_rebind(clnt); - switch (status) { - case -ENOTCONN: - case -EAGAIN: - task->tk_action = call_bind; - if (!RPC_IS_SOFT(task)) - return; /* if soft mounted, test if we've timed out */ case -ETIMEDOUT: task->tk_action = call_timeout; - return; + break; + default: + rpc_exit(task, -EIO); } - rpc_exit(task, -EIO); } /* |