diff options
| author | J. Bruce Fields <bfields@citi.umich.edu> | 2005-06-22 17:16:23 +0000 |
|---|---|---|
| committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2005-06-22 16:07:16 -0400 |
| commit | 6a19275ada9137435da58990c8f8d3f58e170bf1 (patch) | |
| tree | 927f8aa96c9b558a0bed5355dde66df9c0ec8554 /net/sunrpc/auth.c | |
| parent | 438b6fdebf2a2e8573e7290bc176feb4d4475f43 (diff) | |
| download | linux-3.10-6a19275ada9137435da58990c8f8d3f58e170bf1.tar.gz linux-3.10-6a19275ada9137435da58990c8f8d3f58e170bf1.tar.bz2 linux-3.10-6a19275ada9137435da58990c8f8d3f58e170bf1.zip | |
[PATCH] RPC: [PATCH] improve rpcauthauth_create error returns
Currently we return -ENOMEM for every single failure to create a new auth.
This is actually accurate for auth_null and auth_unix, but for auth_gss it's a
bit confusing.
Allow rpcauth_create (and the ->create methods) to return errors. With this
patch, the user may sometimes see an EINVAL instead. Whee.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'net/sunrpc/auth.c')
| -rw-r--r-- | net/sunrpc/auth.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c index 9bcec9b927b..505e2d4b3d6 100644 --- a/net/sunrpc/auth.c +++ b/net/sunrpc/auth.c @@ -66,10 +66,10 @@ rpcauth_create(rpc_authflavor_t pseudoflavor, struct rpc_clnt *clnt) u32 flavor = pseudoflavor_to_flavor(pseudoflavor); if (flavor >= RPC_AUTH_MAXFLAVOR || !(ops = auth_flavors[flavor])) - return NULL; + return ERR_PTR(-EINVAL); auth = ops->create(clnt, pseudoflavor); - if (!auth) - return NULL; + if (IS_ERR(auth)) + return auth; if (clnt->cl_auth) rpcauth_destroy(clnt->cl_auth); clnt->cl_auth = auth; |