diff options
| author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2011-12-27 22:32:41 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-12-27 22:32:41 -0500 |
| commit | aef950b4ba3196622a5bd5e21ab1d63f30658285 (patch) | |
| tree | f4cb91f4517a041ef95c28ad50039b0b2ae6b137 /net/packet | |
| parent | c43c5f39584c0f388a7e5372312c2c48221a4415 (diff) | |
| download | linux-3.10-aef950b4ba3196622a5bd5e21ab1d63f30658285.tar.gz linux-3.10-aef950b4ba3196622a5bd5e21ab1d63f30658285.tar.bz2 linux-3.10-aef950b4ba3196622a5bd5e21ab1d63f30658285.zip | |
packet: fix possible dev refcnt leak when bind fail
If bind is fail when bind is called after set PACKET_FANOUT
sock option, the dev refcnt will leak.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/packet')
| -rw-r--r-- | net/packet/af_packet.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index 3891702b81d..d9d4970b9b0 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -2448,8 +2448,12 @@ static int packet_do_bind(struct sock *sk, struct net_device *dev, __be16 protoc { struct packet_sock *po = pkt_sk(sk); - if (po->fanout) + if (po->fanout) { + if (dev) + dev_put(dev); + return -EINVAL; + } lock_sock(sk); |