diff options
| author | Johannes Berg <johannes.berg@intel.com> | 2012-12-27 17:32:09 +0100 |
|---|---|---|
| committer | Johannes Berg <johannes.berg@intel.com> | 2013-01-03 13:01:45 +0100 |
| commit | ba23d2068d85f6616ea5f92320c04e87d4b9e141 (patch) | |
| tree | 8ea8b7d8ab39ada84c967531875aef24892667d6 /net/mac80211/cfg.c | |
| parent | 21add825f90a50407e0121833c8b7cd2c071c478 (diff) | |
| download | linux-3.10-ba23d2068d85f6616ea5f92320c04e87d4b9e141.tar.gz linux-3.10-ba23d2068d85f6616ea5f92320c04e87d4b9e141.tar.bz2 linux-3.10-ba23d2068d85f6616ea5f92320c04e87d4b9e141.zip | |
cfg80211: disallow more station changes
The following changes are invalid and should be
disallowed when a station already exists:
* supported rates changes, except for TDLS peers
* listen interval changes
* HT capability changes
Disallow them and also update a mac80211 comment
explaining how they would be racy.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net/mac80211/cfg.c')
| -rw-r--r-- | net/mac80211/cfg.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c index f4d12c71928..7d290bce092 100644 --- a/net/mac80211/cfg.c +++ b/net/mac80211/cfg.c @@ -1208,10 +1208,11 @@ static int sta_apply_parameters(struct ieee80211_local *local, sta->sta.aid = params->aid; /* - * FIXME: updating the following information is racy when this - * function is called from ieee80211_change_station(). - * However, all this information should be static so - * maybe we should just reject attemps to change it. + * Some of the following updates would be racy if called on an + * existing station, via ieee80211_change_station(). However, + * all such changes are rejected by cfg80211 except for updates + * changing the supported rates on an existing but not yet used + * TDLS peer. */ if (params->listen_interval >= 0) |