summaryrefslogtreecommitdiff
path: root/net/can
diff options
context:
space:
mode:
authorEric Dumazet <edumazet@google.com>2012-06-14 06:42:44 +0000
committerDavid S. Miller <davem@davemloft.net>2012-06-15 15:30:15 -0700
commit62b1a8ab9b3660bb820d8dfe23148ed6cda38574 (patch)
tree7e6e6702da0e7ec0afe5c4dc6b337e8870b45fae /net/can
parentbc14786a100cc6a81cd060e8031ec481241b418c (diff)
downloadlinux-3.10-62b1a8ab9b3660bb820d8dfe23148ed6cda38574.tar.gz
linux-3.10-62b1a8ab9b3660bb820d8dfe23148ed6cda38574.tar.bz2
linux-3.10-62b1a8ab9b3660bb820d8dfe23148ed6cda38574.zip
net: remove skb_orphan_try()
Orphaning skb in dev_hard_start_xmit() makes bonding behavior unfriendly for applications sending big UDP bursts : Once packets pass the bonding device and come to real device, they might hit a full qdisc and be dropped. Without orphaning, the sender is automatically throttled because sk->sk_wmemalloc reaches sk->sk_sndbuf (assuming sk_sndbuf is not too big) We could try to defer the orphaning adding another test in dev_hard_start_xmit(), but all this seems of little gain, now that BQL tends to make packets more likely to be parked in Qdisc queues instead of NIC TX ring, in cases where performance matters. Reverts commits : fc6055a5ba31 net: Introduce skb_orphan_try() 87fd308cfc6b net: skb_tx_hash() fix relative to skb_orphan_try() and removes SKBTX_DRV_NEEDS_SK_REF flag Reported-and-bisected-by: Jean-Michel Hautbois <jhautbois@gmail.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Tested-by: Oliver Hartkopp <socketcan@hartkopp.net> Acked-by: Oliver Hartkopp <socketcan@hartkopp.net> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/can')
-rw-r--r--net/can/raw.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/net/can/raw.c b/net/can/raw.c
index cde1b4a20f7..46cca3a91d1 100644
--- a/net/can/raw.c
+++ b/net/can/raw.c
@@ -681,9 +681,6 @@ static int raw_sendmsg(struct kiocb *iocb, struct socket *sock,
if (err < 0)
goto free_skb;
- /* to be able to check the received tx sock reference in raw_rcv() */
- skb_shinfo(skb)->tx_flags |= SKBTX_DRV_NEEDS_SK_REF;
-
skb->dev = dev;
skb->sk = sk;