summaryrefslogtreecommitdiff
path: root/mm
diff options
context:
space:
mode:
authorJerome Marchand <jmarchan@redhat.com>2013-04-29 15:08:47 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2013-04-29 15:54:39 -0700
commit2d30d31ea3c5be426ce25607b9bd1835acb85e0a (patch)
tree09b7c5c89755cf32702075ed6806b1343da50c18 /mm
parent465adcf1ea7b2e49b2e0899366624f5532b64012 (diff)
downloadlinux-3.10-2d30d31ea3c5be426ce25607b9bd1835acb85e0a.tar.gz
linux-3.10-2d30d31ea3c5be426ce25607b9bd1835acb85e0a.tar.bz2
linux-3.10-2d30d31ea3c5be426ce25607b9bd1835acb85e0a.zip
swap: redirty page if page write fails on swap file
Since commit 62c230bc1790 ("mm: add support for a filesystem to activate swap files and use direct_IO for writing swap pages"), swap_writepage() calls direct_IO on swap files. However, in that case the page isn't redirtied if I/O fails, and is therefore handled afterwards as if it has been successfully written to the swap file, leading to memory corruption when the page is eventually swapped back in. This patch sets the page dirty when direct_IO() fails. It fixes a memory corruption that happened while using swap-over-NFS. Signed-off-by: Jerome Marchand <jmarchan@redhat.com> Acked-by: Johannes Weiner <hannes@cmpxchg.org> Acked-by: Mel Gorman <mgorman@suse.de> Cc: Hugh Dickins <hughd@google.com> Cc: <stable@vger.kernel.org> [3.6+] Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm')
-rw-r--r--mm/page_io.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/mm/page_io.c b/mm/page_io.c
index 8e0e5c0e7cd..eb3300fa89d 100644
--- a/mm/page_io.c
+++ b/mm/page_io.c
@@ -231,6 +231,8 @@ int __swap_writepage(struct page *page, struct writeback_control *wbc,
if (ret == PAGE_SIZE) {
count_vm_event(PSWPOUT);
ret = 0;
+ } else {
+ set_page_dirty(page);
}
return ret;
}