diff options
author | Boaz Harrosh <bharrosh@panasas.com> | 2007-07-29 22:22:04 +0300 |
---|---|---|
committer | James Bottomley <jejb@mulgrave.localdomain> | 2007-08-04 09:12:48 -0500 |
commit | 0ceb47987d31f8529c60f1e802e0523fcde9492c (patch) | |
tree | 475bcd2d6bfa14a659a3b4612261fc8f9773d0b4 /mm | |
parent | b1ee0795276f976118f832313488e6daf83ff542 (diff) | |
download | linux-3.10-0ceb47987d31f8529c60f1e802e0523fcde9492c.tar.gz linux-3.10-0ceb47987d31f8529c60f1e802e0523fcde9492c.tar.bz2 linux-3.10-0ceb47987d31f8529c60f1e802e0523fcde9492c.zip |
[SCSI] aha152x: preliminary fixes and some comments
hunk by hunk:
- CHECK_CONDITION is what happens to cmnd->status >> 1
or after status_byte() macro. But here it is used
directly on status which means 0x1 which is an undefined
bit in the standard. And is a status that will never
return from a target.
- in busfree_run at the DONE_SC phase we have 3 distinct
operation:
1-if(DONE_SC->SCp.phase & check_condition)
The REQUEST_SENSE command return.
- Restore original command
- Than continue to operation 3.
2-if(DONE_SC->SCp.Status==SAM_STAT_CHECK_CONDITION)
A regular command returned with a status.
- Internally re-Q a REQUEST_SENSE.
- Do not do operation 3.
3-
- Complete the command and return it to scsi-ml
So the 0x2 in both these operations (1,2) means the scsi
check-condition status, hence SAM_STAT_CHECK_CONDITION
- Here the code asks about !(DONE_SC->SCp.Status & not_issued)
but "not_issued" is an enum belonging to the "phase" member
and not to the Status returned from target. The reason this
works is because not_issued==1 and Also CHECK_CONDITION==1
(remember from hunk 1). So actually the code was asking
!(DONE_SC->SCp.Status & CHECK_CONDITION). Which means
"Has the status been read from target yet?"
Staus is read at status_run(). "not_issued" is
cleared in seldo_run() which is usually earlier than
status_run().
So this patch does nothing as far as assembly is concerned
but it does let the reader understand what is going on.
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'mm')
0 files changed, 0 insertions, 0 deletions