diff options
| author | Hugh Dickins <hughd@google.com> | 2012-10-08 16:33:18 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-10-09 16:22:55 +0900 |
| commit | 39b5f29ac1f988c1615fbc9c69f6651ab0d0c3c7 (patch) | |
| tree | d8030f58d542bb3e811d83676b38c5b4b3a16c02 /mm/internal.h | |
| parent | ec4d9f626d5908b6052c2973f37992f1db52e967 (diff) | |
| download | linux-3.10-39b5f29ac1f988c1615fbc9c69f6651ab0d0c3c7.tar.gz linux-3.10-39b5f29ac1f988c1615fbc9c69f6651ab0d0c3c7.tar.bz2 linux-3.10-39b5f29ac1f988c1615fbc9c69f6651ab0d0c3c7.zip | |
mm: remove vma arg from page_evictable
page_evictable(page, vma) is an irritant: almost all its callers pass
NULL for vma. Remove the vma arg and use mlocked_vma_newpage(vma, page)
explicitly in the couple of places it's needed. But in those places we
don't even need page_evictable() itself! They're dealing with a freshly
allocated anonymous page, which has no "mapping" and cannot be mlocked yet.
Signed-off-by: Hugh Dickins <hughd@google.com>
Acked-by: Mel Gorman <mel@csn.ul.ie>
Cc: Rik van Riel <riel@redhat.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michel Lespinasse <walken@google.com>
Cc: Ying Han <yinghan@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/internal.h')
| -rw-r--r-- | mm/internal.h | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/mm/internal.h b/mm/internal.h index 7f72f249bc2..78f25d6cc6a 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -168,9 +168,8 @@ static inline void munlock_vma_pages_all(struct vm_area_struct *vma) } /* - * Called only in fault path via page_evictable() for a new page - * to determine if it's being mapped into a LOCKED vma. - * If so, mark page as mlocked. + * Called only in fault path, to determine if a new page is being + * mapped into a LOCKED vma. If it is, mark page as mlocked. */ static inline int mlocked_vma_newpage(struct vm_area_struct *vma, struct page *page) |