diff options
| author | Guennadi Liakhovetski <g.liakhovetski@gmx.de> | 2012-11-23 20:55:06 +0100 |
|---|---|---|
| committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2012-11-23 20:55:06 +0100 |
| commit | a7227a0faa117d0bc532aea546ae5ac5f89e8ed7 (patch) | |
| tree | ad2843227bd9d9baac592463a86e0f3d485ad9d9 /lib | |
| parent | f4a75d2eb7b1e2206094b901be09adb31ba63681 (diff) | |
| download | linux-3.10-a7227a0faa117d0bc532aea546ae5ac5f89e8ed7.tar.gz linux-3.10-a7227a0faa117d0bc532aea546ae5ac5f89e8ed7.tar.bz2 linux-3.10-a7227a0faa117d0bc532aea546ae5ac5f89e8ed7.zip | |
PM / QoS: fix wrong error-checking condition
dev_pm_qos_add_request() can return 0, 1, or a negative error code,
therefore the correct error test is "if (error < 0)." Checking just for
non-zero return code leads to erroneous setting of the req->dev pointer
to NULL, which then leads to a repeated call to
dev_pm_qos_add_ancestor_request() in st1232_ts_irq_handler(). This in turn
leads to an Oops, when the I2C host adapter is unloaded and reloaded again
because of the inconsistent state of its QoS request list.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions