summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2008-07-06 16:16:15 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2008-07-06 16:16:15 -0700
commit78a8bf69b32980879975f7e31d30386c50bfe851 (patch)
tree577521810087b901f9207f9cdbbe884ced43e490 /lib
parent0f9bfa569d46f2346a53a940b2b9e49a38635732 (diff)
downloadlinux-3.10-78a8bf69b32980879975f7e31d30386c50bfe851.tar.gz
linux-3.10-78a8bf69b32980879975f7e31d30386c50bfe851.tar.bz2
linux-3.10-78a8bf69b32980879975f7e31d30386c50bfe851.zip
vsprintf: split out '%p' handling logic
The actual code is the same, just split out into a helper function. This makes it easier to read, and allows for simple future extension of %p handling. Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib')
-rw-r--r--lib/vsprintf.c20
1 files changed, 11 insertions, 9 deletions
diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 926c7e00e2d..f569feb7662 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -511,6 +511,16 @@ static char *string(char *buf, char *end, char *s, int field_width, int precisio
return buf;
}
+static char *pointer(char *buf, char *end, void *ptr, int field_width, int precision, int flags)
+{
+ flags |= SMALL;
+ if (field_width == -1) {
+ field_width = 2*sizeof(void *);
+ flags |= ZEROPAD;
+ }
+ return number(buf, end, (unsigned long) ptr, 16, field_width, precision, flags);
+}
+
/**
* vsnprintf - Format a string and place it in a buffer
* @buf: The buffer to place the result into
@@ -653,17 +663,9 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args)
continue;
case 'p':
- flags |= SMALL;
- if (field_width == -1) {
- field_width = 2*sizeof(void *);
- flags |= ZEROPAD;
- }
- str = number(str, end,
- (unsigned long) va_arg(args, void *),
- 16, field_width, precision, flags);
+ str = pointer(str, end, va_arg(args, void *), field_width, precision, flags);
continue;
-
case 'n':
/* FIXME:
* What does C99 say about the overflow case here? */