diff options
author | Chuck Lever <chuck.lever@oracle.com> | 2009-04-23 19:32:18 -0400 |
---|---|---|
committer | J. Bruce Fields <bfields@citi.umich.edu> | 2009-04-28 13:54:28 -0400 |
commit | ea068bad27cefc71ab03230dbf01a8f8d98da5ba (patch) | |
tree | e36b3c23598de4233ffae06fa556504082bd20eb /include/linux/sunrpc | |
parent | 0a5372d8a13c3f670bf7c9c4a68ab04c3664fa28 (diff) | |
download | linux-3.10-ea068bad27cefc71ab03230dbf01a8f8d98da5ba.tar.gz linux-3.10-ea068bad27cefc71ab03230dbf01a8f8d98da5ba.tar.bz2 linux-3.10-ea068bad27cefc71ab03230dbf01a8f8d98da5ba.zip |
NFSD: move lockd_up() before svc_addsock()
Clean up.
A couple of years ago, a series of commits, finishing with commit
5680c446, swapped the order of the lockd_up() and svc_addsock() calls
in __write_ports(). At that time lockd_up() needed to know the
transport protocol of the passed-in socket to start a listener on the
same transport protocol.
These days, lockd_up() doesn't take a protocol argument; it always
starts both a UDP and TCP listener. It's now more straightforward to
try the lockd_up() first, then do a lockd_down() if the svc_addsock()
fails.
Careful review of this code shows that the svc_sock_names() call is
used only to close the just-opened socket in case lockd_up() fails.
So it is no longer needed if lockd_up() is done first.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Diffstat (limited to 'include/linux/sunrpc')
0 files changed, 0 insertions, 0 deletions