summaryrefslogtreecommitdiff
path: root/fs
diff options
context:
space:
mode:
authorJan Kara <jack@suse.cz>2006-09-29 02:00:26 -0700
committerLinus Torvalds <torvalds@g5.osdl.org>2006-09-29 09:18:14 -0700
commitb525a7e4445c4702dfc541930747517615c0c72a (patch)
treed6feb0839c37ba70b284d31aa35469c8cee4c113 /fs
parent254e948b2908dd50df9dca4e6ed14b6cc8524fc9 (diff)
downloadlinux-3.10-b525a7e4445c4702dfc541930747517615c0c72a.tar.gz
linux-3.10-b525a7e4445c4702dfc541930747517615c0c72a.tar.bz2
linux-3.10-b525a7e4445c4702dfc541930747517615c0c72a.zip
[PATCH] dquot: add proper locking when using current->signal->tty
Dquot passes the tty to tty_write_message without locking Signed-off-by: Jan Kara <jack@suse.cz> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs')
-rw-r--r--fs/dquot.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/fs/dquot.c b/fs/dquot.c
index 0122a279106..9af789567e5 100644
--- a/fs/dquot.c
+++ b/fs/dquot.c
@@ -834,6 +834,9 @@ static void print_warning(struct dquot *dquot, const char warntype)
if (!need_print_warning(dquot) || (flag && test_and_set_bit(flag, &dquot->dq_flags)))
return;
+ mutex_lock(&tty_mutex);
+ if (!current->signal->tty)
+ goto out_lock;
tty_write_message(current->signal->tty, dquot->dq_sb->s_id);
if (warntype == ISOFTWARN || warntype == BSOFTWARN)
tty_write_message(current->signal->tty, ": warning, ");
@@ -861,6 +864,8 @@ static void print_warning(struct dquot *dquot, const char warntype)
break;
}
tty_write_message(current->signal->tty, msg);
+out_lock:
+ mutex_unlock(&tty_mutex);
}
static inline void flush_warnings(struct dquot **dquots, char *warntype)