diff options
author | Dave Chinner <david@fromorbit.com> | 2010-02-02 10:13:42 +1100 |
---|---|---|
committer | Dave Chinner <david@fromorbit.com> | 2010-02-02 10:13:42 +1100 |
commit | d808f617ad00a413585b806de340feda5ad9a2da (patch) | |
tree | ed03d4d019a9d8b566ffd454e112e9fbce70bad8 /fs/xfs/quota/xfs_dquot_item.h | |
parent | c854363e80b49dd04a4de18ebc379eb8c8806674 (diff) | |
download | linux-3.10-d808f617ad00a413585b806de340feda5ad9a2da.tar.gz linux-3.10-d808f617ad00a413585b806de340feda5ad9a2da.tar.bz2 linux-3.10-d808f617ad00a413585b806de340feda5ad9a2da.zip |
xfs: Don't issue buffer IO direct from AIL push V2
All buffers logged into the AIL are marked as delayed write.
When the AIL needs to push the buffer out, it issues an async write of the
buffer. This means that IO patterns are dependent on the order of
buffers in the AIL.
Instead of flushing the buffer, promote the buffer in the delayed
write list so that the next time the xfsbufd is run the buffer will
be flushed by the xfsbufd. Return the state to the xfsaild that the
buffer was promoted so that the xfsaild knows that it needs to cause
the xfsbufd to run to flush the buffers that were promoted.
Using the xfsbufd for issuing the IO allows us to dispatch all
buffer IO from the one queue. This means that we can make much more
enlightened decisions on what order to flush buffers to disk as
we don't have multiple places issuing IO. Optimisations to xfsbufd
will be in a future patch.
Version 2
- kill XFS_ITEM_FLUSHING as it is now unused.
Signed-off-by: Dave Chinner <david@fromorbit.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'fs/xfs/quota/xfs_dquot_item.h')
-rw-r--r-- | fs/xfs/quota/xfs_dquot_item.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/fs/xfs/quota/xfs_dquot_item.h b/fs/xfs/quota/xfs_dquot_item.h index 5a632531f84..5acae2ada70 100644 --- a/fs/xfs/quota/xfs_dquot_item.h +++ b/fs/xfs/quota/xfs_dquot_item.h @@ -27,10 +27,6 @@ typedef struct xfs_dq_logitem { xfs_log_item_t qli_item; /* common portion */ struct xfs_dquot *qli_dquot; /* dquot ptr */ xfs_lsn_t qli_flush_lsn; /* lsn at last flush */ - unsigned short qli_pushbuf_flag; /* 1 bit used in push_ail */ -#ifdef DEBUG - uint64_t qli_push_owner; -#endif xfs_dq_logformat_t qli_format; /* logged structure */ } xfs_dq_logitem_t; |