summaryrefslogtreecommitdiff
path: root/fs/ubifs
diff options
context:
space:
mode:
authorArtem Bityutskiy <Artem.Bityutskiy@nokia.com>2011-03-25 18:33:57 +0200
committerArtem Bityutskiy <Artem.Bityutskiy@nokia.com>2011-04-05 10:39:40 +0300
commit8b229c76765816796eec7ccd428f03bd8de8b525 (patch)
treefa8e30710d9365d0f26215d0027dd5408ee2d5fc /fs/ubifs
parent0ce790e7d736cedc563e1fb4e998babf5a4dbc3d (diff)
downloadlinux-3.10-8b229c76765816796eec7ccd428f03bd8de8b525.tar.gz
linux-3.10-8b229c76765816796eec7ccd428f03bd8de8b525.tar.bz2
linux-3.10-8b229c76765816796eec7ccd428f03bd8de8b525.zip
UBIFS: do not read flash unnecessarily
This fix makes the 'dbg_check_old_index()' function return immediately if debugging is disabled, instead of executing incorrect 'goto out' which causes UBIFS to: 1. Allocate memory 2. Read the flash On every commit. OK, we do not commit that often, but it is still silly to do unneeded I/O anyway. Credits to coverity for spotting this silly issue. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> Cc: stable@kernel.org
Diffstat (limited to 'fs/ubifs')
-rw-r--r--fs/ubifs/commit.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ubifs/commit.c b/fs/ubifs/commit.c
index b148fbc80f8..1bd01ded712 100644
--- a/fs/ubifs/commit.c
+++ b/fs/ubifs/commit.c
@@ -577,7 +577,7 @@ int dbg_check_old_index(struct ubifs_info *c, struct ubifs_zbranch *zroot)
size_t sz;
if (!(ubifs_chk_flags & UBIFS_CHK_OLD_IDX))
- goto out;
+ return 0;
INIT_LIST_HEAD(&list);