diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2012-04-12 23:47:00 -0400 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2012-04-13 10:12:00 -0400 |
| commit | 96f6f98501196d46ce52c2697dd758d9300c63f5 (patch) | |
| tree | 08d3795842459047a88ade0708fc10c8b91656bb /fs/nfsd/nfs4proc.c | |
| parent | ecca5c3acc0d0933d89abc44e60afb0cc8170e35 (diff) | |
| download | linux-3.10-96f6f98501196d46ce52c2697dd758d9300c63f5.tar.gz linux-3.10-96f6f98501196d46ce52c2697dd758d9300c63f5.tar.bz2 linux-3.10-96f6f98501196d46ce52c2697dd758d9300c63f5.zip | |
nfsd: fix b0rken error value for setattr on read-only mount
..._want_write() returns -EROFS on failure, _not_ an NFS error value.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/nfsd/nfs4proc.c')
| -rw-r--r-- | fs/nfsd/nfs4proc.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c index 2ed14dfd00a..694d526c8f1 100644 --- a/fs/nfsd/nfs4proc.c +++ b/fs/nfsd/nfs4proc.c @@ -841,6 +841,7 @@ nfsd4_setattr(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, struct nfsd4_setattr *setattr) { __be32 status = nfs_ok; + int err; if (setattr->sa_iattr.ia_valid & ATTR_SIZE) { nfs4_lock_state(); @@ -852,9 +853,9 @@ nfsd4_setattr(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, return status; } } - status = fh_want_write(&cstate->current_fh); - if (status) - return status; + err = fh_want_write(&cstate->current_fh); + if (err) + return nfserrno(err); status = nfs_ok; status = check_attr_support(rqstp, cstate, setattr->sa_bmval, |