diff options
author | Trond Myklebust <Trond.Myklebust@netapp.com> | 2012-03-19 13:39:35 -0400 |
---|---|---|
committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2012-03-19 14:15:02 -0400 |
commit | 540a0f7584169651f485e8ab67461fcb06934e38 (patch) | |
tree | 5a5dede243b80f1dca55f651ff2a78eaccff5c50 /fs/nfs/write.c | |
parent | e49a29bd0eacce9d4956c4daf777a330115b369d (diff) | |
download | linux-3.10-540a0f7584169651f485e8ab67461fcb06934e38.tar.gz linux-3.10-540a0f7584169651f485e8ab67461fcb06934e38.tar.bz2 linux-3.10-540a0f7584169651f485e8ab67461fcb06934e38.zip |
SUNRPC: We must not use list_for_each_entry_safe() in rpc_wake_up()
The problem is that for the case of priority queues, we
have to assume that __rpc_remove_wait_queue_priority will move new
elements from the tk_wait.links lists into the queue->tasks[] list.
We therefore cannot use list_for_each_entry_safe() on queue->tasks[],
since that will skip these new tasks that __rpc_remove_wait_queue_priority
is adding.
Without this fix, rpc_wake_up and rpc_wake_up_status will both fail
to wake up all functions on priority wait queues, which can result
in some nasty hangs.
Reported-by: Andy Adamson <andros@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: stable@vger.kernel.org
Diffstat (limited to 'fs/nfs/write.c')
0 files changed, 0 insertions, 0 deletions